Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for ReadmeUriTemplate #3382

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jgonz120
Copy link
Contributor

@jgonz120 jgonz120 commented Jan 7, 2025

No description provided.

@jgonz120 jgonz120 requested review from a team as code owners January 7, 2025 00:12
# README Uri Template

It is possible for a client to build a URL that can be used to download a README for a specific package.
This will enable the clients to render the package's README without downloading the entire package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it also possible for the readme url to be provided in the package metadata (registration) blob? Or is that not yet implemented?

I think it should be made clear to server implementors that they implement one or the other, not both.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not implemented yet, we don't have any commitments from servers to implement that option.

Copy link
Member

@zivkan zivkan Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, this makes me frustrated. Firstly, it imples that we talked to the dozens of 3rd party NuGet server implementors. Secondly, it means that the ReadmeFileUrl public APIs in NuGet.Protocol are now leaky abstractions, since NuGet will never expect it in a search or registration response, which some people consider an anti-pattern and tech debt.

Considering these public APIs are in the unshipped txt, are you able to delete these public APIs before this version of Nuget ships?


@type value | Notes
--------------------------------- | -----
ReadmeUriTemplate/6.13.0 | The initial release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a "server implementor guide" doc that has a chronological list of changes to the NuGet protocol, so it's easy for server implementors to check if they're "up to date" with all client features, and find what's new since the last time they checked. This should be documented on that page.

If you have any suggestions on how to make sure other people who make changes to the protocol know to update that page, without needing a human like me to remind them, please share your ideas.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When do we decide to update that page? For instance, the report abuse resource wasn't added there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the report abuse resource as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants