Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Dummy Muffler Hatches #45

Merged
merged 12 commits into from
Mar 7, 2025

Conversation

D-Alessian
Copy link
Contributor

@D-Alessian D-Alessian commented Mar 6, 2025

What this PR adds:

  • Removes the ability of mufflers to generate ashes, this makes every multiblock that needs mufflers much more lag free
  • Adds a GUI warning to mufflers to explain this to avoid confused players
  • A config option to turn this back on if need be since this may not please all players

Potential issues:

  • I'm really not sure about the placement of :

    • The lang entry for the GUI, and it's naming
    • The placement of the config

    So please give feedback on where I could place this and if there's better naming for it.

  • This would completely break once 2.9 rolls out, but I'm already going to work on a 2.9 compatible version of this code.

The code has been tested, works without issues and eliminates a LOT of lag on some machines as expected. The effect will be most prominent on high parallel multiblocks like:

  • Multi smelter (laggiest multiblock in every world I've had before this PR)
  • GCYMs with mufflers (RHF, Fractionnary distil, Brewery, etc.)
  • Addons like ZBGT that allow huge parallel numbers.

And here is a preview of how the GUI looks in game.
Screenshot 2025-03-06 at 14 13 31

(Yes I did PR this to the correct place this time)

Copy link
Member

@IntegerLimit IntegerLimit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! The change looks good, just a couple comments regarding code quality, and one comment about implementation.

@IntegerLimit IntegerLimit changed the title Muffler hatches rework Allow for Dummy Muffler Hatches Mar 7, 2025
@IntegerLimit IntegerLimit added the enhancement New feature or request label Mar 7, 2025
Copy link
Member

@IntegerLimit IntegerLimit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@IntegerLimit IntegerLimit merged commit 99d95d2 into Nomi-CEu:main Mar 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants