-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for Dummy Muffler Hatches #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessian Dormal <[email protected]>
…e ash anymore Signed-off-by: Alessian Dormal <[email protected]>
Signed-off-by: Alessian Dormal <[email protected]>
…low for a config option Signed-off-by: Alessian Dormal <[email protected]>
…of overwrite Signed-off-by: Alessian Dormal <[email protected]>
…ants it for some reason Signed-off-by: Alessian Dormal <[email protected]>
Signed-off-by: Alessian Dormal <[email protected]>
Signed-off-by: Alessian Dormal <[email protected]>
Signed-off-by: Alessian Dormal <[email protected]>
IntegerLimit
requested changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! The change looks good, just a couple comments regarding code quality, and one comment about implementation.
src/main/java/com/nomiceu/nomilabs/mixin/gregtech/MetaTileEntityMufflerHatchMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/com/nomiceu/nomilabs/mixin/gregtech/MetaTileEntityMufflerHatchMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/com/nomiceu/nomilabs/mixin/gregtech/MetaTileEntityMufflerHatchMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/com/nomiceu/nomilabs/mixin/gregtech/MetaTileEntityMufflerHatchMixin.java
Show resolved
Hide resolved
src/main/java/com/nomiceu/nomilabs/mixin/gregtech/MetaTileEntityMufflerHatchMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/com/nomiceu/nomilabs/mixin/gregtech/MultiblockRecipeLogicMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/com/nomiceu/nomilabs/mixin/gregtech/MultiblockRecipeLogicMixin.java
Show resolved
Hide resolved
Signed-off-by: Alessian Dormal <[email protected]>
Signed-off-by: Alessian Dormal <[email protected]>
Signed-off-by: Alessian Dormal <[email protected]>
IntegerLimit
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR adds:
Potential issues:
I'm really not sure about the placement of :
So please give feedback on where I could place this and if there's better naming for it.
This would completely break once 2.9 rolls out, but I'm already going to work on a 2.9 compatible version of this code.
The code has been tested, works without issues and eliminates a LOT of lag on some machines as expected. The effect will be most prominent on high parallel multiblocks like:
And here is a preview of how the GUI looks in game.

(Yes I did PR this to the correct place this time)