meson: remove unnecessary stuff #373812
Draft
meson: remove unnecessary stuff #373812
+0
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toonn
approved these changes
Jan 15, 2025
emilazy
force-pushed
the
push-mzkuokqmuxvp
branch
from
b0e0328 to
551090a
Compare
Apple ships a 13‐year‐old fork of OpenLDAP. The very few things that use it, like Meson tests, have been adding dependencies on our up‐to‐date OpenLDAP package to get headers. That’s not reliable to mix with the `.tbd` Apple ships, and pulls OpenLDAP into the bootstrap unnecessarily. We continue to strip the `.dylib`s to avoid accidental dependencies on the old version. Packages can still link to Apple’s version with `-framework LDAP`. As very little seems to want the system version, hopefully this won’t have any major compatibility impact.
No longer necessary now that the SDK retains the Apple OpenLDAP fork headers.
Should no longer be necessary now that we’re using Apple’s `cctools` again.
We no longer ship Python < 3.9.
This wasn’t being built in the bootstrap anyway, and we no longer need to skip the Meson tests.
emilazy
force-pushed
the
push-mzkuokqmuxvp
branch
from
551090a to
55fa153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meson changes should be good if they build, but I’d like Randy’s feedback on the
stdenvstuff.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.