doc: fix pypy39 removal #371901
Merged
doc: fix pypy39 removal #371901
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
8.has: documentation
|
The correct fix is to pass a pkgs in L41 that does not allow aliases. |
|
That line specifically wants aliases, or is the variable name just that misleading? |
|
IMO misleading, not sure what it would want with aliases. |
|
Construct this table I guess |
|
Note that the «aliases» it does want are actually declared in the |
github-actions
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 0
FliegendeWurst
force-pushed
the
pypy39-eval
branch
from
28d6c18 to
cd2a21a
Compare
|
Now "fixed" in a future-proof way. |
|
Looks OK to me at a glance and the manual builds again. Let's not block for long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proper fix eludes me, but this will work for now ...
nix-instantiate pkgs/top-level/release.nix -A nixpkgs-manual.x86_64-linuxworksre: #370527 (comment) (@vcunat)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)