-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildFHSEnv: allow specifying executableName
explicitly
#371770
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
3e00dd1
to
914fdee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still learning the language but wouldn't the changes cause a error when either pname or version is not provided rather than only when missing both as the error message seems to indicate is intended?
pname ? throw "You must provide either `name` or `pname`",
version ? throw "You must provide either `name` or `version`",
If they are accessed directly, yes. However they are only accessed via I'll add a note to make this explicit. |
914fdee
to
c97fbaa
Compare
|
c97fbaa
to
2a2c0bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also something I wanted to do. Thank you.
Motivated by https://github.com/NixOS/nixpkgs/pull/369259/files#r1902238426, allows packages to specify a different exe name & pname.
Also simplified some logic with the name fallback, making it clearer what function args are available.
Tested with:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.