Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subversion: remove obsolete Darwin cruft #371316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

subversion: remove obsolete Darwin cruft #371316

wants to merge 1 commit into from

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Jan 6, 2025

It builds fine without any of this.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 6, 2025
@nix-owners nix-owners bot requested a review from lovek323 January 6, 2025 01:36
@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371316

aarch64-darwin

⏩ 2 packages marked as broken and skipped:
  • python312Packages.pysvn
  • python313Packages.pysvn
❌ 35 packages failed to build:
  • apacheHttpdPackages.subversion (apacheHttpdPackages_2_4.subversion)
  • apacheHttpdPackages.subversion.dev (apacheHttpdPackages_2_4.subversion.dev)
  • apacheHttpdPackages.subversion.man (apacheHttpdPackages_2_4.subversion.man)
  • cabal2nix
  • git-doc (git-doc.doc ,gitFull.doc)
  • gitFull
  • gitSVN
  • gitSVN.doc
  • haskellPackages.cabal2nix-unstable
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-update-source
  • nix-update-source.dist
  • patroni
  • patroni.dist
  • perl538Packages.SVNSimple
  • perl538Packages.SVNSimple.devdoc
  • perl540Packages.SVNSimple
  • perl540Packages.SVNSimple.devdoc
  • ydiff (python312Packages.ydiff)
  • ydiff.dist (python312Packages.ydiff.dist)
  • python313Packages.ydiff
  • python313Packages.ydiff.dist
  • rapidsvn
  • subversionClient
  • subversionClient.dev
  • subversionClient.man
  • svn-all-fast-export
  • svn2git
  • svnfs
  • vcstool
  • vcstool.dist
  • wp4nix
✅ 3 packages built:
  • subversion
  • subversion.dev
  • subversion.man

@ethancedwards8
Copy link
Member

Looks like some packages that depend on svn needs that 'cruft'.

@emilazy
Copy link
Member Author

emilazy commented Jan 6, 2025

Fun, it does indeed seem to lead to a libtool error for subversionClient. I’ll look into it tomorrow. The compiler warnings and framework packages are definitely no longer required, but if we still need the autogen.sh invocation it can probably just be made unconditional.

@emilazy emilazy marked this pull request as draft January 6, 2025 02:28
@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371316

x86_64-linux

⏩ 4 packages marked as broken and skipped:
  • kdePackages.umbrello
  • kdePackages.umbrello.debug
  • kdePackages.umbrello.dev
  • kdePackages.umbrello.devtools
❌ 1 package failed to build:
  • ikiwiki-full
✅ 58 packages built:
  • apacheHttpdPackages.subversion (apacheHttpdPackages_2_4.subversion)
  • apacheHttpdPackages.subversion.dev (apacheHttpdPackages_2_4.subversion.dev)
  • apacheHttpdPackages.subversion.man (apacheHttpdPackages_2_4.subversion.man)
  • cabal2nix
  • git-doc (git-doc.debug ,git-doc.doc ,gitFull.doc)
  • gitFull
  • gitFull.debug
  • gitSVN
  • gitSVN.debug
  • gitSVN.doc
  • haskellPackages.cabal2nix-unstable
  • hydra
  • hydra.doc
  • kdePackages.kdev-php
  • kdePackages.kdev-php.debug
  • kdePackages.kdev-php.dev
  • kdePackages.kdev-php.devtools
  • kdePackages.kdev-python
  • kdePackages.kdev-python.debug
  • kdePackages.kdev-python.dev
  • kdePackages.kdev-python.devtools
  • kdePackages.kdevelop
  • kdePackages.kdevelop.debug
  • kdePackages.kdevelop.dev
  • kdePackages.kdevelop.devtools
  • kdesvn
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-update-source
  • nix-update-source.dist
  • patroni
  • patroni.dist
  • perl538Packages.SVNSimple
  • perl538Packages.SVNSimple.devdoc
  • perl540Packages.SVNSimple
  • perl540Packages.SVNSimple.devdoc
  • python312Packages.pysvn
  • ydiff (python312Packages.ydiff)
  • ydiff.dist (python312Packages.ydiff.dist)
  • python313Packages.pysvn
  • python313Packages.ydiff
  • python313Packages.ydiff.dist
  • rapidsvn
  • subversion
  • subversion.dev
  • subversion.man
  • subversionClient
  • subversionClient.dev
  • subversionClient.man
  • svn-all-fast-export
  • svn2git
  • svnfs
  • thcrap-steam-proton-wrapper
  • vcstool
  • vcstool.dist
  • wp4nix

@emilazy emilazy force-pushed the push-kvknplxkrwkp branch from a92f6ab to 80c06df Compare January 6, 2025 15:38
@emilazy
Copy link
Member Author

emilazy commented Jan 6, 2025

subversionClient now builds. Since upstream is apparently switching to CMake, I just made the ./autogen.sh unconditional for now.

@emilazy emilazy marked this pull request as ready for review January 6, 2025 15:39
@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371316

x86_64-linux

⏩ 4 packages marked as broken and skipped:
  • kdePackages.umbrello
  • kdePackages.umbrello.debug
  • kdePackages.umbrello.dev
  • kdePackages.umbrello.devtools
❌ 45 packages failed to build:
  • apacheHttpdPackages.subversion (apacheHttpdPackages_2_4.subversion)
  • apacheHttpdPackages.subversion.dev (apacheHttpdPackages_2_4.subversion.dev)
  • apacheHttpdPackages.subversion.man (apacheHttpdPackages_2_4.subversion.man)
  • cabal2nix
  • haskellPackages.cabal2nix-unstable
  • hydra
  • hydra.doc
  • ikiwiki-full
  • kdePackages.kdev-php
  • kdePackages.kdev-php.debug
  • kdePackages.kdev-php.dev
  • kdePackages.kdev-php.devtools
  • kdePackages.kdev-python
  • kdePackages.kdev-python.debug
  • kdePackages.kdev-python.dev
  • kdePackages.kdev-python.devtools
  • kdePackages.kdevelop
  • kdePackages.kdevelop.debug
  • kdePackages.kdevelop.dev
  • kdePackages.kdevelop.devtools
  • kdesvn
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-update-source
  • nix-update-source.dist
  • patroni
  • patroni.dist
  • python312Packages.pysvn
  • ydiff (python312Packages.ydiff)
  • ydiff.dist (python312Packages.ydiff.dist)
  • python313Packages.pysvn
  • python313Packages.ydiff
  • python313Packages.ydiff.dist
  • rapidsvn
  • subversion
  • subversion.dev
  • subversion.man
  • svn-all-fast-export
  • svnfs
  • thcrap-steam-proton-wrapper
  • vcstool
  • vcstool.dist
  • wp4nix
✅ 14 packages built:
  • git-doc (git-doc.debug ,git-doc.doc ,gitFull.doc)
  • gitFull
  • gitFull.debug
  • gitSVN
  • gitSVN.debug
  • gitSVN.doc
  • perl538Packages.SVNSimple
  • perl538Packages.SVNSimple.devdoc
  • perl540Packages.SVNSimple
  • perl540Packages.SVNSimple.devdoc
  • subversionClient
  • subversionClient.dev
  • subversionClient.man
  • svn2git

aarch64-linux

⏩ 4 packages marked as broken and skipped:
  • kdePackages.umbrello
  • kdePackages.umbrello.debug
  • kdePackages.umbrello.dev
  • kdePackages.umbrello.devtools
❌ 52 packages failed to build:
  • apacheHttpdPackages.subversion (apacheHttpdPackages_2_4.subversion)
  • apacheHttpdPackages.subversion.dev (apacheHttpdPackages_2_4.subversion.dev)
  • apacheHttpdPackages.subversion.man (apacheHttpdPackages_2_4.subversion.man)
  • cabal2nix
  • git-doc (git-doc.debug ,git-doc.doc ,gitFull.doc)
  • gitFull
  • gitFull.debug
  • gitSVN
  • gitSVN.debug
  • gitSVN.doc
  • haskellPackages.cabal2nix-unstable
  • hydra
  • hydra.doc
  • ikiwiki-full
  • kdePackages.kdev-php
  • kdePackages.kdev-php.debug
  • kdePackages.kdev-php.dev
  • kdePackages.kdev-php.devtools
  • kdePackages.kdev-python
  • kdePackages.kdev-python.debug
  • kdePackages.kdev-python.dev
  • kdePackages.kdev-python.devtools
  • kdePackages.kdevelop
  • kdePackages.kdevelop.debug
  • kdePackages.kdevelop.dev
  • kdePackages.kdevelop.devtools
  • kdesvn
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-update-source
  • nix-update-source.dist
  • patroni
  • patroni.dist
  • python312Packages.pysvn
  • ydiff (python312Packages.ydiff)
  • ydiff.dist (python312Packages.ydiff.dist)
  • python313Packages.pysvn
  • python313Packages.ydiff
  • python313Packages.ydiff.dist
  • rapidsvn
  • subversion
  • subversion.dev
  • subversion.man
  • svn-all-fast-export
  • svn2git
  • svnfs
  • thcrap-steam-proton-wrapper
  • vcstool
  • vcstool.dist
  • wp4nix
✅ 7 packages built:
  • perl538Packages.SVNSimple
  • perl538Packages.SVNSimple.devdoc
  • perl540Packages.SVNSimple
  • perl540Packages.SVNSimple.devdoc
  • subversionClient
  • subversionClient.dev
  • subversionClient.man

x86_64-darwin

⏩ 2 packages marked as broken and skipped:
  • python312Packages.pysvn
  • python313Packages.pysvn
❌ 26 packages failed to build:
  • apacheHttpdPackages.subversion (apacheHttpdPackages_2_4.subversion)
  • apacheHttpdPackages.subversion.dev (apacheHttpdPackages_2_4.subversion.dev)
  • apacheHttpdPackages.subversion.man (apacheHttpdPackages_2_4.subversion.man)
  • cabal2nix
  • haskellPackages.cabal2nix-unstable
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-update-source
  • nix-update-source.dist
  • patroni
  • patroni.dist
  • ydiff (python312Packages.ydiff)
  • ydiff.dist (python312Packages.ydiff.dist)
  • python313Packages.ydiff
  • python313Packages.ydiff.dist
  • rapidsvn
  • subversion
  • subversion.dev
  • subversion.man
  • svn-all-fast-export
  • svnfs
  • vcstool
  • vcstool.dist
  • wp4nix
✅ 12 packages built:
  • git-doc (git-doc.doc ,gitFull.doc)
  • gitFull
  • gitSVN
  • gitSVN.doc
  • perl538Packages.SVNSimple
  • perl538Packages.SVNSimple.devdoc
  • perl540Packages.SVNSimple
  • perl540Packages.SVNSimple.devdoc
  • subversionClient
  • subversionClient.dev
  • subversionClient.man
  • svn2git

aarch64-darwin

⏩ 2 packages marked as broken and skipped:
  • python312Packages.pysvn
  • python313Packages.pysvn
❌ 26 packages failed to build:
  • apacheHttpdPackages.subversion (apacheHttpdPackages_2_4.subversion)
  • apacheHttpdPackages.subversion.dev (apacheHttpdPackages_2_4.subversion.dev)
  • apacheHttpdPackages.subversion.man (apacheHttpdPackages_2_4.subversion.man)
  • cabal2nix
  • haskellPackages.cabal2nix-unstable
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-update-source
  • nix-update-source.dist
  • patroni
  • patroni.dist
  • ydiff (python312Packages.ydiff)
  • ydiff.dist (python312Packages.ydiff.dist)
  • python313Packages.ydiff
  • python313Packages.ydiff.dist
  • rapidsvn
  • subversion
  • subversion.dev
  • subversion.man
  • svn-all-fast-export
  • svnfs
  • vcstool
  • vcstool.dist
  • wp4nix
✅ 12 packages built:
  • git-doc (git-doc.doc ,gitFull.doc)
  • gitFull
  • gitSVN
  • gitSVN.doc
  • perl538Packages.SVNSimple
  • perl538Packages.SVNSimple.devdoc
  • perl540Packages.SVNSimple
  • perl540Packages.SVNSimple.devdoc
  • subversionClient
  • subversionClient.dev
  • subversionClient.man
  • svn2git

@emilazy
subversion: remove obsolete Darwin cruft
dbd31d4 
It builds fine without any of this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaneliman khaneliman khaneliman left review comments

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilazy @ethancedwards8 @khaneliman