Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bittorrent NixOS Test: Un-Uncomment seeder takedown #262975

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

tfc
Copy link
Contributor

@tfc tfc commented Oct 23, 2023

Description of changes

Back in 2019, I commented this line while porting the test from perl to python.
Just today i found out that it works (again?), so let's comment it in again.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tfc
Copy link
Contributor Author

tfc commented Oct 23, 2023

@ofborg test bittorrent

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Oct 23, 2023
@tfc tfc requested a review from RaitoBezarius October 23, 2023 17:20
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 23, 2023
@h7x4
Copy link
Member

h7x4 commented Oct 24, 2023

I haven't tested the changes, but I think the commit message looks a bit weird. According to the git log, it seems more conventional to use either nixos/tests: made xyz changes to <service> or nixos/tests/<service>: made xyz changes

@tfc tfc force-pushed the bittorrent-test-fix branch from e6cc84f to 1005fa0 Compare October 24, 2023 06:24
@tfc
Copy link
Contributor Author

tfc commented Oct 24, 2023

I haven't tested the changes, but I think the commit message looks a bit weird. According to the git log, it seems more conventional to use either nixos/tests: made xyz changes to <service> or nixos/tests/<service>: made xyz changes

I adapted it to the convention from your description that you feel is less weird.

@tfc
Copy link
Contributor Author

tfc commented Oct 24, 2023

@ofborg test bittorrent

@tfc tfc merged commit 04c4853 into NixOS:master Oct 27, 2023
@tfc tfc deleted the bittorrent-test-fix branch October 27, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants