Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the opencensus dependency #47

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Get rid of the opencensus dependency #47

merged 5 commits into from
Jan 30, 2025

Conversation

avm
Copy link
Collaborator

@avm avm commented Jan 30, 2025

opencensus.io is causing trouble for module vendoring:
hypermodeinc/badger#2155

So we switch to our fork of go-libp2p-kad-dht, which does not depend on opencensus, and remove the dependency from our fork of badger.

Copy link
Contributor

@dmtrskv dmtrskv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray

@dmtrskv
Copy link
Contributor

dmtrskv commented Jan 30, 2025

A PR description would be nice, since we're open-source now.

@olegrok
Copy link
Contributor

olegrok commented Jan 30, 2025

Please fix a linter

@avm avm changed the title Use our fork of go-lib2p-kad-dht. Get rid of the opencensus dependency Jan 30, 2025
@avm avm removed this pull request from the merge queue due to a manual request Jan 30, 2025
@avm avm enabled auto-merge January 30, 2025 14:24
@avm avm added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 50032d1 Jan 30, 2025
12 checks passed
@avm avm deleted the fork-kad-dht branch January 30, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants