Feature/356 #365
Merged
Feature/356 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results11 files 11 suites 0s ⏱️ Results for commit d18a20b. ♻️ This comment has been updated with latest results. |
mangbaam
reviewed
Jan 27, 2025
|
|
||
| internal interface PopupService { | ||
| @GET("/app/papi/v1/popup") | ||
| suspend fun getPopup(): PopupResponse |
There was a problem hiding this comment.
논의했을 땐 화면 정보를 포함해서 요청한다고 했는데, 그거 반영은 안된거야?
There was a problem hiding this comment.
음... 내가 지난 번에 잘못 이해한 거 같은데...
API에서는 내려주는 view가 화면을 말하는 거 같아
data/src/main/java/com/nexters/boolti/data/network/response/PopupResponse.kt
Show resolved
Hide resolved
data/src/main/java/com/nexters/boolti/data/network/response/PopupResponse.kt
Show resolved
Hide resolved
presentation/src/main/java/com/nexters/boolti/presentation/component/BTDialog.kt
Show resolved
Hide resolved
presentation/src/main/java/com/nexters/boolti/presentation/extension/String.kt
Show resolved
Hide resolved
presentation/src/main/java/com/nexters/boolti/presentation/screen/show/EventDialog.kt
Show resolved
Hide resolved
presentation/src/main/java/com/nexters/boolti/presentation/screen/show/EventDialog.kt
Outdated
Show resolved
Hide resolved
presentation/src/main/java/com/nexters/boolti/presentation/screen/show/ShowScreen.kt
Outdated
Show resolved
Hide resolved
presentation/src/test/java/com/nexters/boolti/presentation/util/ExtractEmphasizedTextTest.kt
Show resolved
Hide resolved
mangbaam
reviewed
Feb 1, 2025
data/src/main/java/com/nexters/boolti/data/datasource/PopupDataSource.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
작업 내용