Feature/360 입장 확인 고도화 #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 9 files 9 suites 0s ⏱️ Results for commit 7af0d0f. ♻️ This comment has been updated with latest results. |
|
전면 카메라 전환 시연 영상은 부끄러워서 안 넣었어 |
mangbaam
requested changes
Jan 11, 2025
presentation/src/main/java/com/nexters/boolti/presentation/QrScanActivity.kt
Outdated
Show resolved
Hide resolved
presentation/src/main/java/com/nexters/boolti/presentation/QrScanActivity.kt
Show resolved
Hide resolved
| @@ -24,6 +30,7 @@ import kotlinx.coroutines.launch | |||
|
|
|||
| @AndroidEntryPoint | |||
| class QrScanActivity : ComponentActivity() { | |||
| var isBackCamera = true | |||
There was a problem hiding this comment.
이 속성을 여기서 관리했을 때 카메라 방향 싱크가 안 맞는 문제는 없을까?
There was a problem hiding this comment.
private fun switchCamera() {
barcodeView.pause()
isBackCamera = !isBackCamera
barcodeView.cameraSettings.requestedCameraId = if (isBackCamera) {
Camera.CameraInfo.CAMERA_FACING_BACK
} else {
Camera.CameraInfo.CAMERA_FACING_FRONT
}
barcodeView.resume()
}
지금 코드가 이렇게 되어 있고, 내 생각엔 없을 거 같긴 한데 혹시 더 좋은 방법이 있을까?
presentation/src/main/java/com/nexters/boolti/presentation/screen/qr/QrScanScreen.kt
Show resolved
Hide resolved
presentation/src/main/java/com/nexters/boolti/presentation/screen/qr/QrScanScreen.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
작업 내용
KakaoTalk_Video_2025-01-09-22-50-26.mp4