feat(phonebook): add WebTop phonebook integration #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce WebTop-to-Phonebook and Phonebook-to-WebTop synchronization scripts and configurations. This includes: - `build-images.sh` updates to build a new `webtop-phonebook` container. - New PHP scripts for bidirectional contact syncing. - Systemd service and timer for scheduled sync operations. - `start.sh` script to manage sync execution. This enables centralized contact management between WebTop and the Phonebook system, improving usability and reducing manual effort.
Add documentation for the new phonebook synchronization system in the README. This includes an overview of the `webtop2phonebook.php` and `pbook2webtop.php` scripts, environment variable setup, and manual configuration steps for enabling the service and timer.
gsanchietti
reviewed
Jan 27, 2025
| 1. Set the environment variables for the phonebook database connection. | ||
| - **`PHONEBOOK_DB_HOST`**: The hostname or IP address of the phonebook | ||
| database, formatted as `host:port`. | ||
| - **`PHONEBOOK_DB_PASSWORD`**: The password for the phonebook database user. |
There was a problem hiding this comment.
Add an example here.
Document also that this configuration is not preserved when the application is restored or moved/cloned.
Possible improvements: add such variables into a new env file, load the envfile from the phonebook unit and add it also to backup.
Co-authored-by: Giacomo Sanchietti <[email protected]>
Co-authored-by: Giacomo Sanchietti <[email protected]>
Co-authored-by: Giacomo Sanchietti <[email protected]>
Stell0
requested changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce WebTop-to-Phonebook and Phonebook-to-WebTop synchronization
scripts and configurations. This includes:
build-images.shupdates to build a newwebtop-phonebookcontainer.start.shscript to manage sync execution.This enables centralized contact management between WebTop and the
Phonebook system.
NethServer/dev#7261