Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tmce plugin #103

Merged
merged 3 commits into from
Jan 29, 2025
Merged

feat: add tmce plugin #103

merged 3 commits into from
Jan 29, 2025

Conversation

gsanchietti
Copy link
Member

@gsanchietti gsanchietti commented Jan 23, 2025

This PR introduces TMCE plugin for installations with a valid subscription.
For license reasons, the plugin can't be distributed to anyone.

Workflow:

  • the webapp systemd unit uses a new TMCE_PLUGIN environment variable saved inside subscription.env: the variable allow mounting a volume where the plugin is stored
  • the 13tmce_plugin step writes the subscription.env environment during the configure-module and when the subscription-event is fired; it also downloads the plugin from NS7 repository using subscription credentials

Please note that download from NS7 repositories may be broken in the future.

The PR fix the build by downloading the charset jar from NethServer infra: freeutils site was down quite often

NethServer/dev#7266

@gsanchietti gsanchietti force-pushed the tmce_plugin branch 2 times, most recently from 1d0bc5c to ef13d56 Compare January 24, 2025 13:43
The download from freeutils site was failing often.
Moved the package to our own infrastructure.
@gsanchietti gsanchietti force-pushed the tmce_plugin branch 5 times, most recently from 588b787 to 57b6d2e Compare January 27, 2025 16:54
Include the jar plugin as encrypted file inside the module image.
The plugin is decrypted when the cluster has a valid subscription.

Subscribe also to subscription-change event to adapt the environment.
@gsanchietti gsanchietti marked this pull request as ready for review January 28, 2025 08:13
@gsanchietti gsanchietti requested a review from Amygos January 28, 2025 08:13
@gsanchietti gsanchietti force-pushed the tmce_plugin branch 2 times, most recently from f21dd83 to fc9187f Compare January 28, 2025 14:50
Avoid to allow download of tmce plugin from a public repository.

As per Amygos request.
@gsanchietti gsanchietti merged commit 9761a12 into main Jan 29, 2025
5 of 8 checks passed
@gsanchietti gsanchietti deleted the tmce_plugin branch January 29, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants