Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[argo] support for @parallel #1927

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

valayDave
Copy link
Collaborator

supported :

not-supported:

  • support for catch

Notes

  • not using the {{retries}} like we do in container templates
  • Instead passing down {{retries}} as a inputs.parameters which will be accessible in the Jobset manifest.
  • Temporary tweek to boto dep to ensure that boto install failures dont fail deployment.
  • instead of relying on the kubernetes object, we freshly create a object in the ArgoContainer templates.
  • Code in the same style as the kubernetes/argo integrations with explicit filling of variables and decoupled abstractions
  • setting annotations explicitly as they wont be passed down from WorkflowTemplate level.
  • support for jobset native success conditions (requires Jobset v0.6 on controller)
  • REFACTORS THAT HAVE WENT INTO THIS COMMIT:
  • [argo][feedback] refactor dag template parameter /output setting - just move conditional block around
  • [argo][feedback] refactor references to task_id_base to task_id_entropy
  • these are set/used in the argo outputs and variable names
  • [argo][feedback] refactor references to task-id-base to task-id-entropy
  • these are uses a Argo Parameter Names.
  • [argo][feedback] refactor to match code style
  • [argo][feedback] refactor to match code style (refactor some conditionals)
  • [argo][feedback] remove k8s client and make KubernetesArgoJobSet directly use kubernetes_sdk
  • [argo][feedback] added environment_variables_from_selectors for code simplification -
  • [argo][feedback] fix comment. - [argo][feedback] refactor condition for readabililty.
  • [argo][feedback] rollback temp boto3 installation change in metaflow env - [argo][feedback] remove rogue type hint

@valayDave valayDave force-pushed the valay/js-argo-integration-oss branch from b3946a7 to b4ec249 Compare July 19, 2024 17:43
> supported :
- foreach + parallel
- parallel with Argo
- dynamically set worker-counts.
- should work with @timeout / @project /@card etc.
- retries working with native Argo
- fully self contained jobset with argo support
    - Requires Jobset v0.6.0 [kubernetes-sigs/jobset#523]

> not-supported:
- support for catch

> Notes
- not using the `{{retries}}` like we do in container templates
- Instead passing down {{retries}} as a `inputs.parameters` which will
be accessible in the Jobset manifest.
- Temporary tweek to boto dep to ensure that boto install failures dont fail deployment.
- instead of relying on the kubernetes object, we freshly create a object in the ArgoContainer templates.
- Code in the same style as the kubernetes/argo integrations with explicit filling of variables and decoupled abstractions
- setting annotations explicitly as they wont be passed down from WorkflowTemplate level.
- support for jobset native success conditions (requires Jobset v0.6 on controller)
- REFACTORS THAT HAVE WENT INTO THIS COMMIT:
    - [argo][feedback] refactor dag template parameter /output setting
        - just move conditional block around
    - [argo][feedback] refactor references to `task_id_base` to `task_id_entropy`
        - these are set/used in the argo outputs and variable names
    - [argo][feedback] refactor references to `task-id-base` to `task-id-entropy`
        - these are uses a Argo Parameter Names.
    - [argo][feedback] refactor to match code style
    - [argo][feedback] refactor to match code style (refactor some conditionals)
    - [argo][feedback] remove k8s client and make `KubernetesArgoJobSet` directly use `kubernetes_sdk`
    - [argo][feedback] added `environment_variables_from_selectors` for code simplification
    - [argo][feedback] fix comment.
    - [argo][feedback] refactor condition for readabililty.
    - [argo][feedback] rollback temp boto3 installation change in metaflow env
    - [argo][feedback] remove rogue type hint
@valayDave valayDave force-pushed the valay/js-argo-integration-oss branch from b4ec249 to 1b3f487 Compare July 19, 2024 18:02
@savingoyal savingoyal merged commit 134fc8f into master Jul 19, 2024
26 checks passed
@savingoyal savingoyal deleted the valay/js-argo-integration-oss branch July 19, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants