Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Spelling #109

wants to merge 2 commits into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Oct 20, 2016

Followup to #107

@@ -70,7 +70,7 @@ def self.options
required: false,
type: :string},
:key_suffix => {name: "Key Suffix",
description: "Provide a key suffix for testing out experimental regularz expressions",
description: "Provide a key suffix for testing out experimental regular expressions",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably skipped this because in some languages z is meaningful suffix and thus there was no reason for me to spend time investigating it.

@@ -1,4 +1,4 @@
class Workflowable::Actions::StatusChangeNotifcationAction < Workflowable::Actions::Action
class Workflowable::Actions::StatusChangeNotificationAction < Workflowable::Actions::Action
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like an API change, although I can't find any consumers

@jsoref jsoref mentioned this pull request Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant