Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign and DKG protocol wrappers for Frost via Protocol trait #194

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kuksag
Copy link
Collaborator

@kuksag kuksag commented Feb 10, 2025

This PR aims to simplify development and maintenance of Frost wrappers.
First attempt to describe an explicit state machine was made here #172.
After coding/reviewing process, a little more time was spent to investigate how cait-sith model of writing protocols can be applied.

Thus, instead of implementing Protocol trait directly, we write an async function, and convert it to the trait via run_protocol. This is where we need to expose some primitives from cait-sith lib, which is done here Near-One/cait-sith#5.

@@ -10,7 +10,7 @@ anyhow = "1.0.92"
async-trait = "0.1.83"
axum = "0.7.9"
borsh = { version = "1.5.1", features = ["derive"] }
cait-sith = { git = "https://github.com/Near-One/cait-sith.git", features = ["k256"], rev = "1bb67e2a04f01cc7835ce4d8a611064229acc10c" }
cait-sith = { git = "https://github.com/kuksag/cait-sith", rev = "59d032582196f3bf7aee402b924b36094bdc4c51", features = ["k256", "internals"] }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can not be merge until Near-One/cait-sith#5

@kuksag kuksag requested a review from robin-near February 10, 2025 18:21
@kuksag kuksag linked an issue Feb 10, 2025 that may be closed by this pull request
@SimonRastikian SimonRastikian self-requested a review February 12, 2025 15:19
@kuksag kuksag marked this pull request as draft February 15, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support frost signatures
1 participant