Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies - a suggestion #434

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

davisthomas-aily
Copy link

@davisthomas-aily davisthomas-aily commented Jan 7, 2025

Suggestions for the pyproject.toml that should be considerably less limiting.

@davisthomas-aily davisthomas-aily marked this pull request as ready for review January 7, 2025 14:51
@nnansters
Copy link
Contributor

Awesome, cheers for that @davisthomas-aily !

Sorry for the silence on the original PR, I've been on holiday for the end of year but have spent some evenings testing out combinations of "the big dependencies" (numpy, pandas, scipy, scikit-learn, ...) to find out where to limit the versions.

I would suggest keeping this PR open and I'll pick the updates to the smaller dependencies from here, then put those into the #433 PR if that's fine by you. I should have some time to wrap that up tomorrow. Still have a small breaking API change in scikit-learn to deal with, then we can be compatible with basically any version listed here.

Appreciate the proactive approach! And happy new year 🎉 !

@davisthomas-aily
Copy link
Author

Happy new year! This sounds great, I'll close this once #433 is done then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants