Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdfium: use the variables rather than literal constants #412

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mara004
Copy link

@mara004 mara004 commented Feb 6, 2025

Description

Avoid literal constants, and use the variables from the bindings instead.
Also, avoid a needless call of bitmap.get_info() (will disappear in v5). Instead, take the .mode from the bitmap object directly.
Disclaimer: untested, patch created through GH's web interface.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Feb 6, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@jdye64
Copy link
Collaborator

jdye64 commented Feb 7, 2025

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants