Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nsys profiling to ESM-2 benchmarking and apply rope #11762

Open
wants to merge 7 commits into
base: aot/bert_660m
Choose a base branch
from

Conversation

sichu2023
Copy link
Collaborator

No description provided.

@sichu2023 sichu2023 changed the title add nsys profiling to ESM-2 benchmarking add nsys profiling to ESM-2 benchmarking and apply rope Jan 6, 2025
@sichu2023 sichu2023 requested a review from suiyoubi January 6, 2025 17:39
Copy link
Contributor

github-actions bot commented Jan 8, 2025

beep boop 🤖: 🚨 The following files must be fixed before merge!


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.llm.bert.model.esm
nemo/collections/llm/bert/model/esm.py:7:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/llm/bert/model/esm.py:16:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/llm/bert/model/esm.py:25:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/llm/bert/model/esm.py:3:0: W0611: Unused HuggingFaceBertModel imported from nemo.collections.llm.bert.model.bert (unused-import)
************* Module nemo2_esm2_tp
nemo2_esm2_tp.py:52:0: C0301: Line too long (153/119) (line-too-long)
nemo2_esm2_tp.py:53:0: C0301: Line too long (179/119) (line-too-long)
nemo2_esm2_tp.py:28:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo2_esm2_tp.py:22:0: W0611: Unused AutoTokenizer imported from nemo.collections.common.tokenizers (unused-import)

-----------------------------------
Your code has been rated at 9.04/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants