Ssc 1074 ippppa to attic plus patch to develop #1280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edit comments to explain elevation, time zone requirements
Address SAM issue 1990 - 5 minute weather data header info
Address SAM issue 2004
Avoid giving free energy at the end of a grid outage
…ppppa_to_attic
sjanzou
reviewed
Feb 19, 2025
| } | ||
| state->q0 = q_upper; | ||
|
|
There was a problem hiding this comment.
Was this previously incorrect or are you taking the opportunity to update formatting?
There was a problem hiding this comment.
Previously incorrect. See #1278
| @@ -479,7 +479,12 @@ bool windfile::open( const std::string &file ) | |||
| std::vector<std::string> hdr; | |||
| int ncols = locate2(m_buf, hdr, ','); | |||
|
|
|||
| for (size_t i = 0; (int)i < ncols; i++) | |||
| lat = std::numeric_limits<float>::quiet_NaN(); | |||
| @@ -30,7 +30,6 @@ set(SSC_SRC | |||
| cmod_csp_common_eqns.cpp | |||
| cmod_csp_common_eqns.h | |||
| cmod_csp_dsg_lf_ui.cpp | |||
| cmod_csp_heatsink.cpp | |||
There was a problem hiding this comment.
Whoops - looks like I used --ours a little too aggressively on the merge. This is a good reason to do two PRs instead of combining this with changes to develop. I'll close this one.
Yes. We can do separate PRs for that if you prefer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this pulled along a few patch issues as well.
Fixes #1074 - moves unused cmod file to attic
Pairs with NREL/SAM#2011