Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge this yet] Hide toolbar when an AOI is created #1406

Open
wants to merge 1 commit into
base: feat#1289-simplified-aoi-creation
Choose a base branch
from

Conversation

AliceR
Copy link
Member

@AliceR AliceR commented Jan 27, 2025

Based on our discussions around improving the user experience when creating a new AOI after a shape has already been drawn, this PR introduces an alternative user flow:

  • Users can only create a new AOI (via selection, drawing, or uploading) after deleting the existing one.
  • While an AOI is present, the toolbar for creating new AOIs will be hidden, reducing the risk of unintentional overwrites and clarifying the workflow.

This proposal is a variation (Version B ☺️) of the current approach in #1395 (Version A). It emphasizes deliberate action on the part of the user, ensuring that any new AOI creation starts from a clean slate.

Feedback on whether this alternative flow better aligns with user needs would be greatly appreciated! We could even run some A/B testing with both of the deploy preview links!

@AliceR AliceR requested review from faustoperez and aboydnw January 27, 2025 16:31
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit ab869dd
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/6797b4e13dabc10008799e2b
😎 Deploy Preview https://deploy-preview-1406--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the intention to make it explicit to users that they need to delete the current AOI to be able to draw or select a new one.

However, what the user actually wants is more like "Start over" or "Draw or select a new AOI". Not delete. I don't think anyone ever only wants "delete" - why would you delete if you do not want to draw or select a new AOI?

So I think the idea is good to make it clear that there can only be one AOI and if you want a different one, you are effectively starting over.

But the delete button will be a blocker, because users are looking to do something else - ultimately the draw/select UI again.

Copy link

@faustoperez faustoperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Jonas, the presence of the delete area button is still a bit wonky. I don't think we have the flow figured out yet. Looks good though, since this is one side of an A/B test

@hanbyul-here hanbyul-here changed the title Hide toolbar when an AOI is created [Do not merge this yet] Hide toolbar when an AOI is created Jan 30, 2025
@aboydnw
Copy link
Contributor

aboydnw commented Jan 30, 2025

I agree with the comments above. I think there is something here, but see my comment in #1395

Open to either path forward, though, so raise your hand if you're in strong disagreement. Just trying to break up the ice a bit to get things flowing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants