Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

myoBack and myoBack-exosuit model #28

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

cherylwang20
Copy link

No description provided.

Copy link
Contributor

@Vittorio-Caggiano Vittorio-Caggiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the model seems to be quite unstable
there are also some geometries that seem to be outside the body e.g. Cylinder2_cylinder
there are some muscles that are attached outside the mody
image

<mesh name="torso_geom_11_thoracic2_s" file="../myo_sim/meshes/thoracic2_s.stl" scale="0.87 0.87 0.87"/>
<mesh name="torso_geom_12_thoracic1_s" file="../myo_sim/meshes/thoracic1_s.stl" scale="0.87 0.87 0.87"/>
<mesh name="torso_geom_13_ribcage_s" file="../myo_sim/meshes/ribcage_s.stl" scale="0.87 0.87 0.87"/>
<mesh name="lower_exo_belt_geom_1" file="../myo_sim/meshes/LowerExoBelt.stl" scale="0.0013 0.0013 0.0013"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should those assets be moved into a myoback_assets_exosuit?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ff16d34
is this what you have in mind?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in terms of muscle attaching outside of the body, is this what you are looking for? (using the abdomen muscle as an example)
image
Image before adjustments for comparison:
image

</body>
<body name="lumbar4" pos="0.009 0.0321 0">
<inertial pos="0.0170296 0.018 0" quat="0.707107 0 0 0.707107" mass="1.799" diaginertia="0.01643 0.01123 0.0052"/>
<joint name="L4_L5_FE" pos="0 0 0" axis="0 0 1" limited="false" range="-100000 100000"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this range (along with many others) seems to be too big and can produce numerical instabilities. Is it also physiological to be so big?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the ranges here to a reasonable one, and change some muscle jumping issues:
6a6f4dd

@Vittorio-Caggiano
Copy link
Contributor

@cherylwang20 can you also add a readme with the information on the model and how it was validated?

@cherylwang20
Copy link
Author

@cherylwang20 can you also add a readme with the information on the model and how it was validated?

a04a100 here

Copy link
Contributor

@Vittorio-Caggiano Vittorio-Caggiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add more details about the model e.g. number of muscles/joints

also, can you add the model info and a pic in the main readme?

back/README.md Outdated

## General:

The myoArm mujoco musculoskeletal (MSK) model is generated from: Constrained Lumbar Spine model - 210 [https://simtk.org/projects/lumbarspine] from Opensim.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this myoArm or myoBack (I think it is trunk though as it has also abdomen and not only back

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it was a typo, updated the changes here:
cf66ed0

@cherylwang20 cherylwang20 changed the title myoBack and myoBack-exosuit model myoTorso and myoTorso-exosuit model Dec 19, 2024
@cherylwang20 cherylwang20 changed the title myoTorso and myoTorso-exosuit model myoBack and myoBack-exosuit model Dec 19, 2024
README.md Outdated
@@ -15,6 +15,7 @@ The models present in the library are:
| **MyoLeg** <br> - 20 Degree of Freedom (DoF) <br> - 80 muscles | <img src="https://user-images.githubusercontent.com/12837145/236839645-e34eab3f-0358-4ca8-8ae0-68a5c08585e4.png" width="200">|
| **MyoArm** <br> - 27 Degree of Freedom (DoF) <br> - 63 muscles | <img src="https://github.com/MyoHub/myo_sim/assets/23240128/1f57c639-b7de-4bbb-a3c2-d2c29716e6c8" width="200">|
| **MyoOSL** <br> - 19 Degree of Freedom (DoF) <br> - 54 muscles, 2 torque actuators | <img src="https://github.com/elladyr/myo_sim/assets/5383997/ec9dfc65-94ba-457f-8375-594c0e3a89b5" width="200">|
| **MyoBack** <br> - 3 Degree of Freedom (DoF) <br> - 210 muscles, 18 joints | <img src="https://github.com/cherylwang20/myo_sim/blob/cec3ce211a516a8798ed2edf9486a0814a0965da/MyoBack.png?raw=true" width="200">|
Copy link
Contributor

@Vittorio-Caggiano Vittorio-Caggiano Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the description let's use only the degrees of freedom like in the other descriptions

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model actually have 18 joints, but three main virtual joints: flexion extension, lateral bending, and axial
rotation, are controlled and mapped onto all other ones.
Let me know what is a better way of representing writing it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have the other models expressing the model in terms of DOF ... let's do that in this case too
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, updated here 79fd3ce

@cherylwang20
Copy link
Author

cherylwang20 commented Dec 22, 2024

I also have created an env to achieve a simple 'upright' position for this model. Do you want me to add it as well?

@Vittorio-Caggiano
Copy link
Contributor

I also have created an env to achieve a simple 'upright' position for this model. Do you want me to add it as well?

if it is a task, better to have it in myosuite

Copy link
Contributor

@Vittorio-Caggiano Vittorio-Caggiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants