Skip to content
This repository has been archived by the owner on Feb 3, 2025. It is now read-only.

Change password #638

Merged
merged 2 commits into from
Jul 8, 2023
Merged

Change password #638

merged 2 commits into from
Jul 8, 2023

Conversation

benthecarman
Copy link
Collaborator

wasn't working for me when testing, getting this code for now

Wait for idb to save after changing password
@futurepaul
Copy link
Contributor

need to throw an error on export if password required

@AnthonyRonning AnthonyRonning marked this pull request as ready for review July 8, 2023 05:13
@AnthonyRonning AnthonyRonning changed the title WIP: Change password Change password Jul 8, 2023
@AnthonyRonning
Copy link
Contributor

AnthonyRonning commented Jul 8, 2023

Should work now. Also swapped out the encryption method, and stored the key in memory for multiple writes.

Should also throw an error on export if it can't decrypt the mnemonic.

Copy link
Collaborator Author

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing

Copy link
Collaborator Author

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AnthonyRonning AnthonyRonning merged commit b3938c1 into master Jul 8, 2023
@AnthonyRonning AnthonyRonning deleted the change-password branch July 8, 2023 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants