This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
fix(rename): replace Elk with Mozilla.social - MOSOWEB-98 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtfluckey
commented
Nov 15, 2023
| @@ -7,7 +7,7 @@ const route = useRoute() | |||
| if (process.server && !route.path.startsWith('/settings')) { | |||
| useHead({ | |||
| meta: [ | |||
| { property: 'og:url', content: `https://elk.zone${route.path}` }, | |||
| { property: 'og:url', content: `https://mozilla.social${route.path}` }, | |||
There was a problem hiding this comment.
Hopefully this makes sharing links better
wtfluckey
commented
Nov 15, 2023
| @@ -52,7 +52,7 @@ function percolateStatus(status) { | |||
| addStatus(status) | |||
| } | |||
|
|
|||
| nuxtApp.hook('elk-logo:click', () => { | |||
| nuxtApp.hook('moz-logo:click', () => { | |||
There was a problem hiding this comment.
These elk-logo -> moz-logo changes aren't visible to the user, but it felt like a reasonable change to make for a tiny bit of developer experience improvement
wtfluckey
commented
Nov 15, 2023
| "app_logo": "Elk Logo", | ||
| "app_name": "Elk", | ||
| "app_logo": "Mozilla Logo", | ||
| "app_name": "Mozilla.social", |
There was a problem hiding this comment.
German translation - updated app name & logo
wtfluckey
commented
Nov 15, 2023
| @@ -92,7 +92,7 @@ | |||
| }, | |||
| "app_desc_short": "Decentralized social media powered by Mastodon", | |||
| "app_logo": "Mozilla Logo", | |||
| "app_name": "Mozilla Social", | |||
| "app_name": "Mozilla.social", | |||
There was a problem hiding this comment.
Went ahead and updated the English app name to match the Mozilla.social syntax that product decided on
wtfluckey
force-pushed
the
fix/elk-to-moso
branch
from
a4ff05e to
bc2beca
Compare
gvn
approved these changes
Nov 15, 2023
anthony-liddle
approved these changes
Nov 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Anywhere it's visible to the user, replace
elkwithMozilla.social. MOSOWEB-98Implementation Details
elkin the repo. Most of these are in documentation, config, constants, translations (that aren't supported) and dead components. I was pretty thorough in my chasing down of anything that might be visible to the user, and I think I've covered everything