This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
fix(tags) - Expose masto object to client [SOCIALPLAT-601] #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yep, I suspect #16 needs to be reverted. Check https://mozilla.social/tags/indieweb - this page is broken because the masto object does not exist when the page is server-side rendered. |
|
@bakulf sure, do with as you please. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with SOCIALPLAT-601 and others is that we render the page in the client but
$mastodoes not exist there. With this change, the rendering works as expected. This issue is a regression of commit26c5ccb964fed99588fed86c0c2fc193723b6013.@bassrock why you moved masto to client only? The commit does not contain a description.