Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

feat: A draft for the about page in Elk [MOSOWEB-54] #78

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Conversation

bakulf
Copy link

@bakulf bakulf commented Nov 3, 2023

This PR contains a draft for the about page in Elk. It works as expected but I think it needs a bit of love with the style (vue, css are not my thing (yet?)).

A few considerations:

  • I don't know if you have templates for PRs.
  • in theory, we don't need the server-side call to fetch the extended_description endpoint, but I see this as a common pattern elsewhere (invite page)
  • to push to prod, we need to change the HAProxy, adding use_backend elk if { path_beg /about }

@bakulf bakulf requested a review from a team as a code owner November 3, 2023 08:47
@bakulf bakulf changed the title A draft for the about page in Elk feat: A draft for the about page in Elk Nov 3, 2023
@bakulf bakulf changed the title feat: A draft for the about page in Elk feat: A draft for the about page in Elk [MOSOWEB-54] Nov 3, 2023
@jpezninjo
Copy link

I think the server-side call pattern is just a way to have consistent language between web and mobile. Totally can go away imo

Copy link

@jpezninjo jpezninjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one small comment about the email. The page looks great already to me :D

@bakulf
Copy link
Author

bakulf commented Nov 6, 2023

I added the authorization header for the instance API endpoint.
We need to revisit how we want to interact with mastodon >=4.2.1

@bakulf
Copy link
Author

bakulf commented Nov 6, 2023

I added the authorization header for the instance API endpoint. We need to revisit how we want to interact with mastodon >=4.2.1

OK. It seems a wrong config for stage. We are good to go.

@bakulf bakulf merged commit c253b15 into main Nov 6, 2023
3 checks passed
@bakulf bakulf deleted the aboutInElk branch November 6, 2023 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants