fix(posts): Post Button interactions (Like, Boost, Respond, Share, Report) [MOSOWEB-44] #75

jpezninjo · 2023-10-31T00:07:22Z

Goal

Adding glean events for Post Button interactions (Like, Boost, Respond, Share, Report)
MOSOWEB-44

To Do:

Add glean event for a generic "reply" event
Add sending mastodon_post_id
Add glean event for "home.reply" to set up pattern for different feeds
Do the rest of the post actions - boost, like, bookmark, reply
Do the rest of the feeds - favorites, likes, local, federated

I'd love feedback/perspectives on:

Did I miss any other feeds?
Should I rename "post.reblog" to "post.boost" to match the engagement_type?

"ui_identifier": "post.reblog",
"mastodon_status_id": "111330231322029109",
"engagement_type": "boost"

Implementation Decisions

The feed names are defined in the "Timeline" components. I did some light prop drilling instead of doing something involving the page URL.

For example, here's Home

<TimelineHome feedName="home.feed">
    <TimelinePaginator feedName>
        <StatusCard feedName>
            <StatusActionsMore feedName>     <--- Report
            <StatusActions feedName>         <--- Like/boost/reply/bookmark

Obligatory list of new events

5 action types, multiplied by the 4 feeds + standalone page

// Standalone post
post.open-reply
post.reblog
post.unreblog
post.favourite
post.unfavourite
post.bookmark
post.unbookmark
post.report
// Account feed
account.feed.post.open-reply
account.feed.post.reblog
account.feed.post.unreblog
account.feed.post.favourite
account.feed.post.unfavourite
account.feed.post.bookmark
account.feed.post.unbookmark
account.feed.post.report
// Home feed
home.feed.post.open-reply
home.feed.post.reblog
home.feed.post.unreblog
home.feed.post.favourite
home.feed.post.unfavourite
home.feed.post.bookmark
home.feed.post.unbookmark
home.feed.post.report
// Favorites feed
favorites.feed.post.open-reply
favorites.feed.post.reblog
favorites.feed.post.unreblog
favorites.feed.post.favourite
favorites.feed.post.unfavourite
favorites.feed.post.bookmark
favorites.feed.post.unbookmark
favorites.feed.post.report
// Bookmarks feed
bookmarks.feed.post.open-reply
bookmarks.feed.post.reblog
bookmarks.feed.post.unreblog
bookmarks.feed.post.favourite
bookmarks.feed.post.unfavourite
bookmarks.feed.post.bookmark
bookmarks.feed.post.unbookmark
bookmarks.feed.post.report
// Local feed
local.feed.post.open-reply
local.feed.post.reblog
local.feed.post.unreblog
local.feed.post.favourite
local.feed.post.unfavourite
local.feed.post.bookmark
local.feed.post.unbookmark
local.feed.post.report
// Federated feed
federated.feed.post.open-reply
federated.feed.post.reblog
federated.feed.post.unreblog
federated.feed.post.favourite
federated.feed.post.unfavourite
federated.feed.post.bookmark
federated.feed.post.unbookmark
federated.feed.post.report

…ts map

…es feed, local feed, and federated feed

jpezninjo · 2023-10-31T16:53:20Z

components/status/StatusActions.vue

+  toggleReblog()
+}
+
+function favourite() {


using the UK English version of "favorite" to match the called toggleFavourite, even though there's a useStarFavoriteIcon elsewhere in this file 😠

grumble grumble, i really dislike that these have been mixed throughout the entire repo but one problem at a time i suppose

jpezninjo · 2023-10-31T17:23:56Z

components/status/StatusActions.vue


 const props = defineProps<{
  status: mastodon.v1.Status
+  feedName?: string


optional prop bc used by StatusCard and StatusDetail

jpezninjo · 2023-10-31T17:26:17Z

components/status/StatusActionsMore.vue


 const props = defineProps<{
  status: mastodon.v1.Status
  details?: boolean
  command?: boolean
+  feedName?: string


optional prop bc used by StatusCard and StatusDetail

jpezninjo · 2023-10-31T17:29:18Z

components/status/StatusActions.vue

@@ -23,14 +26,36 @@ const {
  toggleReblog,
 } = $(useStatusActions(props))

+function recordEngagement(engagementAction: String) {
+  const analyticsId = feedName ? `${feedName}.post.${engagementAction}` : `post.${engagementAction}`


Kinda messy ternary. I am open to suggestions here.

… reply event

wtfluckey · 2023-11-07T17:20:22Z

I think we are missing a scope for when the user is taking actions on an individual's feed. I haven't tested everything yet, but I ran into a couple things:

Seeing that warning feedName is expecting undefined, got Undefined when navigating to an individual's feed
Also seeing that if you reply to a post from an individual's feed, we get a post.reply engagement event, but it's missing the engagement_type (screenshot below)

wtfluckey · 2023-11-07T17:24:53Z

components/status/StatusActions.vue

+function reblog() {
+  recordEngagement('reblog')
+  toggleReblog()
+}


Do you know if data/product wants to have events for undoing a reblog, favorite or bookmark? Since these functions are toggles, if you un-reblog/favorite/bookmark something it just sends the same engagement event and I'm curious if anyone has mentioned wanting to have the false toggle cases tracked too

Me and Aly talked to Kirill. We are going to use separate ui_identifiers and for the "undo" actions, the engagement_type will be general

… optional

jpezninjo · 2023-11-07T19:13:03Z

Pushed up making feedName optional + adding a feed name to the accounts feed to solve Aly's comment about events on an individual's feed

wtfluckey

great work on this!

jpezninjo added 13 commits October 30, 2023 16:20

fix(posts): analytics for home.feed.post.reply, good starting point

d0b303d

fix(posts): setup for standalone posts

7aecd40

fix(posts): reblog

034c76a

fix(posts): recordEngagement function

171056d

fix(posts): favorite

4ab3c49

fix(posts): favorite

32bb7b2

fix(posts): mastodon_status_id

3472e20

fix(posts): engagement types for the 8 events so far, set up postEven…

b44088e

…ts map

fix(posts): report

82d4989

fix(posts): favorites feed

df64fbb

fix(posts): bookmarks feed

cc37101

fix(posts): local and federated feeds

86c6a98

fix(posts): whoops, missed engagement_type on bookmarks feed, favorit…

e8a6aa1

…es feed, local feed, and federated feed

jpezninjo requested a review from a team as a code owner October 31, 2023 00:07

fix(posts): rename 'thing' to something actually appropriate

8538808

jpezninjo commented Oct 31, 2023

View reviewed changes

jpezninjo changed the title ~~[draft] fix(posts): Post Button interactions (Like, Boost, Respond, Share, Report) [MOSOWEB-44]~~ fix(posts): Post Button interactions (Like, Boost, Respond, Share, Report) [MOSOWEB-44] Oct 31, 2023

jpezninjo commented Oct 31, 2023

View reviewed changes

fix(posts): make feedName optional in StatusActionsMore

333b6fd

jpezninjo commented Oct 31, 2023

View reviewed changes

jpezninjo added 2 commits November 2, 2023 09:08

fix(posts): update reply ui_identifier to avoid conflicting to actual…

a77f933

… reply event

fix(posts): make feedName for StatusCards option

e0b5ea7

wtfluckey reviewed Nov 7, 2023

View reviewed changes

jpezninjo and others added 4 commits November 7, 2023 10:20

fix(posts): feedname for account feed, make prop in TimelinePaginator…

4f190f3

… optional

fix(posts): change post reply 'reply' to 'open-reply'

39e3647

fix(posts): account feed events engagement_type's

503c6ba

Merge branch 'main' into fix/posts-buttons-engagement-events

ac60309

jpezninjo added 2 commits November 7, 2023 12:02

fix(posts): do separate events for undo actions

1b49549

fix(posts): bad merge

f5e732d

wtfluckey approved these changes Nov 7, 2023

View reviewed changes

Merge branch 'main' into fix/posts-buttons-engagement-events

90acbfb

anthony-liddle approved these changes Nov 8, 2023

View reviewed changes

jpezninjo merged commit 9f4385a into main Nov 8, 2023
3 checks passed

jpezninjo deleted the fix/posts-buttons-engagement-events branch November 8, 2023 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(posts): Post Button interactions (Like, Boost, Respond, Share, Report) [MOSOWEB-44] #75

fix(posts): Post Button interactions (Like, Boost, Respond, Share, Report) [MOSOWEB-44] #75

jpezninjo commented Oct 31, 2023 •

edited

Loading

jpezninjo Oct 31, 2023 •

edited

Loading

wtfluckey Nov 7, 2023

jpezninjo Oct 31, 2023

jpezninjo Oct 31, 2023

jpezninjo Oct 31, 2023

wtfluckey commented Nov 7, 2023

wtfluckey Nov 7, 2023 •

edited

Loading

jpezninjo Nov 7, 2023

jpezninjo commented Nov 7, 2023

wtfluckey left a comment

fix(posts): Post Button interactions (Like, Boost, Respond, Share, Report) [MOSOWEB-44] #75

fix(posts): Post Button interactions (Like, Boost, Respond, Share, Report) [MOSOWEB-44] #75

Conversation

jpezninjo commented Oct 31, 2023 • edited Loading

Goal

To Do:

I'd love feedback/perspectives on:

Implementation Decisions

Obligatory list of new events

jpezninjo Oct 31, 2023 • edited Loading

Choose a reason for hiding this comment

wtfluckey Nov 7, 2023

Choose a reason for hiding this comment

jpezninjo Oct 31, 2023

Choose a reason for hiding this comment

jpezninjo Oct 31, 2023

Choose a reason for hiding this comment

jpezninjo Oct 31, 2023

Choose a reason for hiding this comment

wtfluckey commented Nov 7, 2023

wtfluckey Nov 7, 2023 • edited Loading

Choose a reason for hiding this comment

jpezninjo Nov 7, 2023

Choose a reason for hiding this comment

jpezninjo commented Nov 7, 2023

wtfluckey left a comment

Choose a reason for hiding this comment

jpezninjo commented Oct 31, 2023 •

edited

Loading

jpezninjo Oct 31, 2023 •

edited

Loading

wtfluckey Nov 7, 2023 •

edited

Loading