This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
fix(posts): track when users click links within posts [MOSOWEB-49] #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpezninjo
commented
Oct 27, 2023
| @@ -16,6 +18,13 @@ function onclick(evt: MouseEvent | KeyboardEvent) { | |||
| const text = window.getSelection()?.toString() | |||
| if (!el && !text) | |||
| go(evt) | |||
There was a problem hiding this comment.
Is it worth wondering if it would be safer to place the analytics call before this go to future-proof for links changing to redirects instead of opening in new tab?
This train of thought stems from login/signup button clicks intermittently failing to show up on the debug tool (probably due to doing redirects)
There was a problem hiding this comment.
Were you able to discern when the go function gets called? I haven't been able to figure it out.
There was a problem hiding this comment.
@wtfluckey Yup. When you click on a post in a feed and it takes you to the url for the standalone post.
jpezninjo
changed the title
jpezninjo
changed the title
wtfluckey
approved these changes
Nov 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: When a user clicks a link within a post, we need to log an engagement event. MOSOWEB-49
To Do:
Example of a post with a link
Engagement event showing up in Debug Ping Viewer
