fix(posts): rename 'thing' to something actually appropriate

components/status/StatusActions.vue

@@ -5,14 +5,14 @@ import { engagementDetails } from '~~/telemetry/engagementDetails'
 
 const props = defineProps<{
   status: mastodon.v1.Status
-  thing?: string
+  feedName?: string
   details?: boolean
   command?: boolean
 }>()
 
 const focusEditor = inject<typeof noop>('focus-editor', noop)
 
-const { details, command, thing } = $(props)
+const { details, command, feedName } = $(props)
 
 const userSettings = useUserSettings()
 const useStarFavoriteIcon = usePreferences('useStarFavoriteIcon')
@@ -27,7 +27,7 @@ const {
 } = $(useStatusActions(props))
 
 function recordEngagement(engagementAction: String) {
-  const analyticsId = thing ? `${thing}.post.${engagementAction}` : `post.${engagementAction}`
+  const analyticsId = feedName ? `${feedName}.post.${engagementAction}` : `post.${engagementAction}`
   engagement.record({ ui_identifier: analyticsId, mastodon_status_id: status.id, ...engagementDetails[analyticsId] })
 }
 

components/status/StatusActionsMore.vue

@@ -8,14 +8,14 @@ const props = defineProps<{
   status: mastodon.v1.Status
   details?: boolean
   command?: boolean
-  thing: string
+  feedName: string
 }>()
 
 const emit = defineEmits<{
   (event: 'afterEdit'): void
 }>()
 
-const { details, command, thing } = $(props)
+const { details, command, feedName } = $(props)
 
 const {
   status,
@@ -125,7 +125,7 @@ function showFavoritedAndBoostedBy() {
 }
 
 function report() {
-  const analyticsId = thing ? `${thing}.post.report` : 'post.report'
+  const analyticsId = feedName ? `${feedName}.post.report` : 'post.report'
   engagement.record({ ui_identifier: analyticsId, mastodon_status_id: status.id, ...engagementDetails[analyticsId] })
 
   openReportDialog(status.account, status)

components/status/StatusCard.vue

@@ -9,7 +9,7 @@ const props = withDefaults(
     hover?: boolean
     inNotification?: boolean
     isPreview?: boolean
-    thing: string
+    feedName: string
 
     // If we know the prev and next status in the timeline, we can simplify the card
     older?: mastodon.v1.Status
@@ -172,7 +172,7 @@ const forceShow = ref(false)
                 </div>
               </div>
             </div>
-            <StatusActionsMore v-if="actions !== false" :status="status" me--2 :thing="thing" />
+            <StatusActionsMore v-if="actions !== false" :status="status" me--2 :feed-name="feedName" />
           </div>
 
           <!-- Content -->
@@ -184,7 +184,7 @@ const forceShow = ref(false)
             :in-notification="inNotification"
             mb2 :class="{ 'mt-2 mb1': isDM }"
           />
-          <StatusActions v-if="actions !== false" v-show="!getPreferences(userSettings, 'zenMode')" :status="status" :thing="thing" />
+          <StatusActions v-if="actions !== false" v-show="!getPreferences(userSettings, 'zenMode')" :status="status" :feed-name="feedName" />
         </div>
       </template>
     </div>

components/timeline/TimelineBookmarks.vue

@@ -3,5 +3,5 @@ const paginator = useMastoClient().v1.bookmarks.list()
 </script>
 
 <template>
-  <TimelinePaginator end-message="common.no_bookmarks" :paginator="paginator" thing="bookmarks.feed" />
+  <TimelinePaginator end-message="common.no_bookmarks" :paginator="paginator" feed-name="bookmarks.feed" />
 </template>

components/timeline/TimelineFavourites.vue

@@ -3,5 +3,5 @@ const paginator = useMastoClient().v1.favourites.list()
 </script>
 
 <template>
-  <TimelinePaginator end-message="common.no_favourites" :paginator="paginator" thing="favorites.feed" />
+  <TimelinePaginator end-message="common.no_favourites" :paginator="paginator" feed-name="favorites.feed" />
 </template>

components/timeline/TimelineHome.vue

@@ -18,6 +18,6 @@ function onPublish(status) {
 <template>
   <div>
     <PublishWidget draft-key="home" border="b base" @published="onPublish" />
-    <TimelinePaginator ref="homePaginator" v-bind="{ paginator, stream }" :preprocess="reorderAndFilter" context="home" thing="home.feed" />
+    <TimelinePaginator ref="homePaginator" v-bind="{ paginator, stream }" :preprocess="reorderAndFilter" context="home" feed-name="home.feed" />
   </div>
 </template>

components/timeline/TimelinePaginator.vue

@@ -13,7 +13,7 @@ const { paginator, stream, account, buffer = 10, endMessage = true } = definePro
   preprocess?: (items: mastodon.v1.Status[]) => mastodon.v1.Status[]
   buffer?: number
   endMessage?: boolean | string
-  thing: string
+  feedName: string
 }>()
 
 const commonPaginator = ref(null)
@@ -44,11 +44,11 @@ const showOriginSite = $computed(() =>
     <template #default="{ item, older, newer, active }">
       <template v-if="virtualScroller">
         <DynamicScrollerItem :item="item" :active="active" tag="article">
-          <StatusCard :status="item" :context="context" :older="older" :newer="newer" :thing="thing" />
+          <StatusCard :status="item" :context="context" :older="older" :newer="newer" :feed-name="feedName" />
         </DynamicScrollerItem>
       </template>
       <template v-else>
-        <StatusCard :status="item" :context="context" :older="older" :newer="newer" :thing="thing" />
+        <StatusCard :status="item" :context="context" :older="older" :newer="newer" :feed-name="feedName" />
       </template>
     </template>
     <template v-if="context === 'account' " #done="{ items }">

components/timeline/TimelinePublic.vue

@@ -10,6 +10,6 @@ function reorderAndFilter(items: mastodon.v1.Status[]) {
 
 <template>
   <div>
-    <TimelinePaginator v-bind="{ paginator, stream }" :preprocess="reorderAndFilter" context="public" thing="federated.feed" />
+    <TimelinePaginator v-bind="{ paginator, stream }" :preprocess="reorderAndFilter" context="public" feed-name="federated.feed" />
   </div>
 </template>

components/timeline/TimelinePublicLocal.vue

@@ -5,6 +5,6 @@ const stream = useStreaming(client => client.v1.stream.streamCommunityTimeline()
 
 <template>
   <div>
-    <TimelinePaginator v-bind="{ paginator, stream }" context="public" thing="local.feed" />
+    <TimelinePaginator v-bind="{ paginator, stream }" context="public" feed-name="local.feed" />
   </div>
 </template>