chore: fix CI error; use docker compose instead of old style and new rust version #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the CI image, ubuntu-latest uses the latest version of Docker, which no longer supports the old-style docker-compose command.
a following error happens if we use v1.71.0 to compile:
error[E0659]: `cbc` is ambiguous
--> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/russh-0.45.0/src/cipher/mod.rs:26:5
|
26 | use cbc::CbcWrapper;
| ^^^ ambiguous name
|
= note: ambiguous because of multiple potential import sources
= note: `cbc` could refer to a crate passed with `--extern`
= help: use `::cbc` to refer to this crate unambiguously
note: `cbc` could also refer to the module defined here
--> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/russh-0.45.0/src/cipher/mod.rs:38:1
|
38 | pub(crate) mod cbc;
| ^^^^^^^^^^^^^^^^^^^
= help: use `self::cbc` to refer to this module unambiguously
error: future cannot be sent between threads safely
--> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/russh-0.45.0/src/server/mod.rs:683:29
|
683 | let join = tokio::spawn(session.run(stream, handler));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ future returned by `run` is not `Send`
|
= help: the trait `for<'a> std::marker::Sync` is not implemented for `(dyn cipher::OpeningKey + std::marker::Send + 'a)`
note: future is not `Send` as this value is used across an await
--> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/russh-0.45.0/src/cipher/mod.rs:265:10
|
264 | .read_exact(&mut buffer.buffer[cipher.packet_length_to_read_for_block_length()..])
| ------ has type `&(dyn cipher::OpeningKey + std::marker::Send + 'a)` which is not `Send`
265 | .await?;
| ^^^^^ - `cipher` is later dropped here
| |
| await occurs here, with `cipher` maybe used later
help: consider moving this into a `let` binding to create a shorter lived borrow
--> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/russh-0.45.0/src/cipher/mod.rs:264:40
|
264 | .read_exact(&mut buffer.buffer[cipher.packet_length_to_read_for_block_length()..])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: required by a bound in `tokio::spawn`
--> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.39.2/src/task/spawn.rs:167:21
|
165 | pub fn spawn<F>(future: F) -> JoinHandle<F::Output>
| ----- required by a bound in this function
166 | where
167 | F: Future + Send + 'static,
| ^^^^ required by this bound in `spawn`
error: future cannot be sent between threads safely
--> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/russh-0.45.0/src/client/mod.rs:723:29
|
723 | let join = tokio::spawn(session.run(stream, handler, Some(encrypted_signal)));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ future returned by `run` is not `Send`
|
= help: the trait `for<'a> std::marker::Sync` is not implemented for `(dyn cipher::OpeningKey + std::marker::Send + 'a)`
note: future is not `Send` as this value is used across an await
--> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/russh-0.45.0/src/cipher/mod.rs:265:10
|
264 | .read_exact(&mut buffer.buffer[cipher.packet_length_to_read_for_block_length()..])
| ------ has type `&(dyn cipher::OpeningKey + std::marker::Send + 'a)` which is not `Send`
265 | .await?;
| ^^^^^ - `cipher` is later dropped here
| |
| await occurs here, with `cipher` maybe used later
help: consider moving this into a `let` binding to create a shorter lived borrow
--> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/russh-0.45.0/src/cipher/mod.rs:264:40
|
264 | .read_exact(&mut buffer.buffer[cipher.packet_length_to_read_for_block_length()..])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: required by a bound in `tokio::spawn`
--> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.39.2/src/task/spawn.rs:167:21
|
165 | pub fn spawn<F>(future: F) -> JoinHandle<F::Output>
| ----- required by a bound in this function
166 | where
167 | F: Future + Send + 'static,
| ^^^^ required by this bound in `spawn`
For more information about this error, try `rustc --explain E0659`.
error: could not compile `russh` (lib) due to 3 previous errors
warning: build failed, waiting for other jobs to finish...
Miyoshi-Ryota
changed the title
Miyoshi-Ryota
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.