Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Debug for Client #46

Merged
merged 3 commits into from
Oct 21, 2023
Merged

impl Debug for Client #46

merged 3 commits into from
Oct 21, 2023

Conversation

cybersoulK
Copy link
Contributor

@cybersoulK cybersoulK commented Oct 20, 2023

Implement Debug for Client
also for ClientHandler since it can, and in case russh implements Debug for Handle some day, then we use the derive macro.

@cybersoulK
Copy link
Contributor Author

cybersoulK commented Oct 20, 2023

and expose russh::client::Config to use with Client::connect_with_config

Copy link
Owner

@Miyoshi-Ryota Miyoshi-Ryota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Miyoshi-Ryota Miyoshi-Ryota merged commit 1a6ee27 into Miyoshi-Ryota:main Oct 21, 2023
2 checks passed
@Miyoshi-Ryota
Copy link
Owner

Miyoshi-Ryota commented Oct 21, 2023

@cybersoulK I've released as 0.8.1 to crates.io. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants