Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for #41 and #42 #43

Merged
merged 2 commits into from
Oct 20, 2023
Merged

test: add test for #41 and #42 #43

merged 2 commits into from
Oct 20, 2023

Conversation

Miyoshi-Ryota
Copy link
Owner

@Miyoshi-Ryota Miyoshi-Ryota commented Oct 20, 2023

I have also checked that that the test is failed without #41.

test client::tests::server_check_by_known_hosts_for_hostname ... FAILED

@Miyoshi-Ryota Miyoshi-Ryota force-pushed the test-for-#41_#42 branch 2 times, most recently from d56c9f7 to 4b2452c Compare October 20, 2023 14:11
@Miyoshi-Ryota
Copy link
Owner Author

@cybersoulK
For your information, I've added tests for your works #41 and #42.
I thought this would be helpful for how to add tests, so I mention you.

To run the tests, simply install docker and run the shell script ./tests/run_unit_tests.sh.
(Unfortunately, it doesn't seem to work on the M1 Mac you're probably using.😭)

@Miyoshi-Ryota Miyoshi-Ryota merged commit 1b33bad into main Oct 20, 2023
@Miyoshi-Ryota Miyoshi-Ryota deleted the test-for-#41_#42 branch October 20, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant