Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script migration #444

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

rwike77
Copy link

@rwike77 rwike77 commented Dec 14, 2023

How to article on using Azure OpenAI to migrate scripts to Microsoft Graph PowerShell

@rwike77
Copy link
Author

rwike77 commented Dec 14, 2023

In progress, do not merge.

Copy link
Contributor

Learn Build status updates of commit edffd4b:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
microsoftgraph/graph-powershell-1.0/Microsoft.Graph.Applications/Get-MgApplication.md ❌Error Details
microsoftgraph/docs-conceptual/migrate_scripts.md ⚠️Warning Details
microsoftgraph/docs-conceptual/toc.yml ⚠️Warning Details
microsoftgraph/graph-powershell-1.0/Microsoft.Graph.Applications/index.yml ⚠️Warning Details

microsoftgraph/graph-powershell-1.0/Microsoft.Graph.Applications/Get-MgApplication.md

  • Line 0, Column 0: [Error: MAML2Yaml_LoadFileFailed]
Failed to load file: C:/LocalRun/W/yi5y-s/microsoftgraph/graph-powershell-1.0/Microsoft.Graph.Applications/Get-MgApplication.md:32:(240) '

## PERMISSIONS

'
 Unexpected header name PERMISSIONS, please try to use PlatyPS validate the content

microsoftgraph/docs-conceptual/migrate_scripts.md

  • Line 27, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to <blockquote>

microsoftgraph/docs-conceptual/toc.yml

  • Line 49, Column 11: [Warning: file-not-found - See documentation] Invalid file link: 'migrate-scripts.md'.

microsoftgraph/graph-powershell-1.0/Microsoft.Graph.Applications/index.yml

  • Line 19, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgApplication'.
  • Line 112, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnedObjectAsGroup'.
  • Line 113, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnedObjectAsServicePrincipal'.
  • Line 114, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnedObjectCount'.
  • Line 115, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnedObjectCountAsApplication'.
  • Line 116, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnedObjectCountAsAppRoleAssignment'.
  • Line 117, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnedObjectCountAsEndpoint'.
  • Line 118, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnedObjectCountAsGroup'.
  • Line 119, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnedObjectCountAsServicePrincipal'.
  • Line 120, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwner'.
  • Line 121, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnerAsAppRoleAssignment'.
  • Line 122, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnerAsEndpoint'.
  • Line 123, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnerAsServicePrincipal'.
  • Line 124, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnerAsUser'.
  • Line 125, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnerByRef'.
  • Line 126, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnerCount'.
  • Line 127, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnerCountAsAppRoleAssignment'.
  • Line 128, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnerCountAsEndpoint'.
  • Line 129, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnerCountAsServicePrincipal'.
  • Line 130, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalOwnerCountAsUser'.
  • Line 131, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalRemoteDesktopSecurityConfiguration'.
  • Line 132, Column 5: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Applications.Get-MgServicePrincipalRemoteDesktopSecurityConfigurationTargetDeviceGroup'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 706c79c:

✅ Validation status: passed

File Status Preview URL Details
microsoftgraph/docs-conceptual/migrate-scripts.md ✅Succeeded View (graph-powershell-1.0 || graph-powershell-beta)
microsoftgraph/docs-conceptual/toc.yml ✅Succeeded View (graph-powershell-1.0 || graph-powershell-beta)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit feb7d22:

✅ Validation status: passed

File Status Preview URL Details
microsoftgraph/docs-conceptual/migrate-scripts.md ✅Succeeded View (graph-powershell-1.0 || graph-powershell-beta)
microsoftgraph/docs-conceptual/toc.yml ✅Succeeded View (graph-powershell-1.0 || graph-powershell-beta)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 55ebb47:

✅ Validation status: passed

File Status Preview URL Details
microsoftgraph/docs-conceptual/migrate-scripts.md ✅Succeeded View (graph-powershell-1.0 || graph-powershell-beta)
microsoftgraph/docs-conceptual/toc.yml ✅Succeeded View (graph-powershell-1.0 || graph-powershell-beta)

For more details, please refer to the build report.

For any questions, please:

Copy link
Collaborator

@omondiatieno omondiatieno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwike77,

Thank you very much for drafting this and for creating the AI model. It's going to simplify the migration work by a great deal.

I left a minor suggestion on how to reduce the length of the article but otherwise, it looks great.

I'll set up some time next week to set up the project on my machine and test the Python script using this guidance. I'll let you know if I run into any issues.

microsoftgraph/docs-conceptual/migrate-scripts.md Outdated Show resolved Hide resolved
# General exception
print(f"Error updating script from {file}. Exception occurred: {e}")
```
## Prompts used with the GPT-4 model
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prompts content is very good and important for the audience. I'm not sure if we can have it hosted somewhere else, like maybe on the readme for the Python app, then we can point the readers to it from this article. I feel like the article is quite long as it is and cutting off this section will shorten it considerably.

Let me know what you think.

Copy link
Contributor

Learn Build status updates of commit f9d9a9e:

✅ Validation status: passed

File Status Preview URL Details
microsoftgraph/docs-conceptual/migrate-scripts.md ✅Succeeded View (graph-powershell-1.0 || graph-powershell-beta)
microsoftgraph/docs-conceptual/toc.yml ✅Succeeded View (graph-powershell-1.0 || graph-powershell-beta)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 6c78e24:

✅ Validation status: passed

File Status Preview URL Details
microsoftgraph/docs-conceptual/migrate-scripts.md ✅Succeeded View (graph-powershell-1.0 || graph-powershell-beta)
microsoftgraph/docs-conceptual/toc.yml ✅Succeeded View (graph-powershell-1.0 || graph-powershell-beta)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 2a2607f:

✅ Validation status: passed

File Status Preview URL Details
microsoftgraph/docs-conceptual/migrate-scripts.md ✅Succeeded View (graph-powershell-1.0 || graph-powershell-beta)
microsoftgraph/docs-conceptual/toc.yml ✅Succeeded View (graph-powershell-1.0 || graph-powershell-beta)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 052f89e:

✅ Validation status: passed

File Status Preview URL Details
microsoftgraph/docs-conceptual/migrate-scripts.md ✅Succeeded View (graph-powershell-1.0 || graph-powershell-beta)
microsoftgraph/docs-conceptual/toc.yml ✅Succeeded View (graph-powershell-1.0 || graph-powershell-beta)

For more details, please refer to the build report.

For any questions, please:

Copy link
Collaborator

@msewaweru msewaweru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @rwike77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants