Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update screenshots & fix 404s in "Inspect CSS Grid" #3248

Merged
merged 13 commits into from
Aug 19, 2024
Merged

Update screenshots & fix 404s in "Inspect CSS Grid" #3248

merged 13 commits into from
Aug 19, 2024

Conversation

captainbrosset
Copy link
Contributor

@captainbrosset captainbrosset commented Aug 13, 2024 •
edited by mikehoffms
Loading

@captainbrosset captainbrosset added the cat: devtools DevTools-related content. label Aug 13, 2024
@mikehoffms mikehoffms changed the title Update screenshots and fix 404 links on the Inspect CSS Grid article Update screenshots & fix 404s in "Inspect CSS Grid" Aug 13, 2024
mikehoffms
mikehoffms approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved per Writer/Editor review after Writer/Editor pass on .md file.

mikehoffms
mikehoffms requested changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@mikehoffms mikehoffms left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls update values & text in webpage to match latest pngs @captainbrosset per Comment

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit ccfcc5a:

✅ Validation status: passed

File Status Preview URL Details
elements-tool/elements-tool.md ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/css/grid-images/grid-discover-grid.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/grid-images/grid-extend-grid-lines.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/grid-images/grid-grid-overlays-color.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/grid-images/grid-grid-overlays-highlight.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/grid-images/grid-grid-overlays.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/grid-images/grid-hide-line-labels.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/grid-images/grid-highlight-grid.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/grid-images/grid-layout-pane.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/grid-images/grid-show-area-names.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/grid-images/grid-show-line-names.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/grid-images/grid-show-line-numbers.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/grid-images/grid-show-track-sizes.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/grid-images/show-element-in-element-panel-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/grid.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

mikehoffms
mikehoffms approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved per Writer/Editor review after changes were made.

@captainbrosset captainbrosset merged commit 6a274d6 into main Aug 19, 2024
2 checks passed
@captainbrosset captainbrosset deleted the user/pabrosse/grid branch August 19, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehoffms mikehoffms mikehoffms approved these changes

Assignees
No one assigned
Labels
cat: devtools DevTools-related content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@captainbrosset @mikehoffms