Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on NavigateToString limit and common error #3236

Merged
merged 5 commits into from
Jul 25, 2024
Merged

Conversation

aluhrs13
Copy link
Contributor

@aluhrs13 aluhrs13 commented Jul 23, 2024

Rendered article section for review:

There's a few conversations on Twitter about the size limit of NavigateToString not being obvious, and the error being hard to understand.

This PR replaces a redundant "Additional web resources" section with one calling out the size limit, and including the error string in hopes of improving discoverability.

Outline of headings

# Working with local content in WebView2 apps

<!-- ============================== -->
## Selecting an approach

<!-- ============================== -->
## Loading local content by navigating to a file URL

#### Considerations for loading local content by navigating to a file URL
###### Cross-origin resources
###### Origin-based DOM APIs
###### DOM APIs requiring secure context
###### Dynamic content
###### Additional web resources
###### Additional web resources resolved in WebView2 process

#### APIs for loading local content by navigating to a file URL
#### Example of a file URL
#### Example of navigating to a file URL

<!-- ============================== -->
## Loading local content by navigating to an HTML string

#### Considerations for loading local content by navigating to an HTML string - HERE
###### Origin-based DOM APIs
###### DOM APIs requiring secure context
###### Dynamic content
###### Additional web resources
###### Additional web resources resolved in WebView2 process

#### APIs for loading local content by navigating to an HTML string
#### Example string representation of a webpage
#### Example of navigating to an HTML string

<!-- ============================== -->
## Loading local content by using virtual host name mapping

#### Considerations for loading local content by using virtual host name mapping
###### Origin-based DOM APIs
###### DOM APIs requiring secure context
###### Dynamic content
###### Additional web resources
###### Additional web resources resolved in WebView2 process

#### APIs for loading local content by using virtual host name mapping
#### Example of virtual host name mapping

<!-- ============================== -->
## Loading local content by handling the WebResourceRequested event
#### Custom scheme registration

#### Considerations for loading local content by handling the WebResourceRequested event
###### Origin-based DOM APIs
###### DOM APIs requiring secure context
###### Dynamic content
###### Additional web resources
###### Additional web resources resolved in WebView2 process

#### APIs for loading local content by handling the WebResourceRequested event
#### Example of handling the WebResourceRequested event

<!-- ============================== -->
## See also

AB#52734029

There's a few conversations on Twitter about the size limit of `NavigateToString` not being obvious, and the error being hard to understand.

This replaces a redundant "Additional web resources" section with one calling out the size limit, and including the error string in hopes of improving discoverability.
@aluhrs13 aluhrs13 requested a review from mikehoffms July 23, 2024 16:34
@mikehoffms mikehoffms self-requested a review July 24, 2024 01:37
Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved PR after pushed commit for writer/editor review.

@mikehoffms mikehoffms added the cat: webview2 WebView-related content. label Jul 24, 2024
Copy link

Learn Build status updates of commit dbf1880:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/docfx.json ✅Succeeded
microsoft-edge/webview2/concepts/working-with-local-content.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 9226f5e:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/docfx.json ✅Succeeded
microsoft-edge/webview2/concepts/working-with-local-content.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 5410b1b:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/webview2/concepts/working-with-local-content.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@Reezaali Reezaali merged commit 63e25fe into main Jul 25, 2024
2 checks passed
@Reezaali Reezaali deleted the aluhrs13-patch-1 branch July 25, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: webview2 WebView-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants