-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service worker no longer required, for Install UI to appear #3215
Service worker no longer required, for Install UI to appear #3215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a new commit to remove the TODOs, rephrase the parts that still needed to be rephrased, and update the how-to/index tutorial's content and screenshots.
microsoft-edge/progressive-web-apps-chromium/how-to/best-practices.md
Outdated
Show resolved
Hide resolved
…ices.md Co-authored-by: Michael Hoffman <[email protected]>
microsoft-edge/progressive-web-apps-chromium/how-to/service-workers.md
Outdated
Show resolved
Hide resolved
microsoft-edge/progressive-web-apps-chromium/how-to/service-workers.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this, but let's do what you suggested:
- Use the singular service worker where it makes sense.
- Change the TOC accordingly.
- Mention faster, reliable, and offline as benefits of the service worker.
microsoft-edge/progressive-web-apps-chromium/how-to/service-workers.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My last comments on this are minor improvements, so I'm approving this PR.
Rendered docset for review:
Changes made by this PR:
AB#52267798