Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Focus Mode] New content and images for the Network request blocking tool #2890

Conversation

captainbrosset
Copy link
Contributor

@captainbrosset captainbrosset commented Oct 23, 2023

New images and content for the Network request blocking tool article.
I also removed the last section, because it was essentially a repeat of the first section.

Before: https://learn.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/network-request-blocking/network-request-blocking-tool
After: https://review.learn.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/network-request-blocking/network-request-blocking-tool?branch=pr-en-us-2890

AB#47204968

@captainbrosset captainbrosset added cat: devtools DevTools-related content. focus-mode-screenshots These PRs are about renewing screenshots in the DevTools docs for Focus Mode labels Oct 23, 2023
Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writer/Editor review pass

@learn-build-service-prod
Copy link

Learn Build status updates of commit fe0f8b4:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/network-request-blocking/network-request-blocking-tool.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/network-request-blocking/network-request-blocking-tool-images/blocked-images.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/network-request-blocking/network-request-blocking-tool-images/block-network-request.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/network-request-blocking/network-request-blocking-tool-images/block-request-from-network-tool.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/network-request-blocking/network-request-blocking-tool-images/edit-blocked-request.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/network-request-blocking/network-request-blocking-tool-images/more-tabs-icon-light-theme.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/network-request-blocking/network-request-blocking-tool-images/network-request-blocking-tool.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/network-request-blocking/network-request-blocking-tool-images/network-request-blocking-tool-not-blocked.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/network-request-blocking/network-request-blocking-tool-images/network-request-blocking-tool-remove-all-patterns-icon.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/network-request-blocking/network-request-blocking-tool-images/remove-blocked-request.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/network-request-blocking/network-request-blocking-tool-images/toggle-request-blocking.png ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writer/Editor final review

@captainbrosset captainbrosset merged commit de0c2b2 into user/pabrosse/focus-mode-july-2023 Oct 24, 2023
1 check passed
@captainbrosset captainbrosset deleted the user/pabrosse/focus-mode-network-blocking branch October 24, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: devtools DevTools-related content. focus-mode-screenshots These PRs are about renewing screenshots in the DevTools docs for Focus Mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants