Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Focus Mode] New images and content for the DOM getting started guide #2884

Merged
merged 8 commits into from
Oct 24, 2023
Merged

[Focus Mode] New images and content for the DOM getting started guide #2884

merged 8 commits into from
Oct 24, 2023

Conversation

captainbrosset
Copy link
Contributor

@captainbrosset captainbrosset commented Oct 20, 2023 •
edited
Loading

@captainbrosset captainbrosset added cat: devtools DevTools-related content. focus-mode-screenshots These PRs are about renewing screenshots in the DevTools docs for Focus Mode labels Oct 20, 2023
mikehoffms
mikehoffms requested changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writer/Editor pass

@learn-build-service-prod

This comment was marked as outdated.

Sign in to view
mikehoffms
mikehoffms requested changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writer/Editor review 2

mikehoffms
mikehoffms approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writer/editor final review, with minor comments

@learn-build-service-prod
Copy link

Learn Build status updates of commit 7cee666:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/dom/index.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/dom/index-images/break-attribute-modifications-break-on-attribute-modifications.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/dom/index-images/copy-js-path-console-query-selector.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-break-attribute-modifications-sources-paused-on.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-break-attribute-modifications-break-on-attribute-modifications.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-copy-js-path-console-query-selector.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-edit-attributes-highlighted.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-edit-attributes-inline-css.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-edit-content.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-edit-html-editor.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-edit-html-editor-closed.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-edit-node-type-button.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-hide-a-node.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-navigate-dom-tree-keyboard-ringo.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-navigate-dom-tree-keyboard-ul.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-reference-currently-selected-node-console-1.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-reference-currently-selected-node-console-2.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-right-click-right-side.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-scroll-into-view-dropdown.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-search-nodes-highlight.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-select-element-page-inspect.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-highlighted-store-global-variable-console-temp1.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-elements-reorder-dom-nodes.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-glitch-dom-examples-michelangelo-elements-highlighted.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/dom/index-images/dom-glitch-dom-examples-michelangelo-inspect.png ✅Succeeded n/a (file deleted or renamed)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit dd82065 into user/pabrosse/focus-mode-july-2023 Oct 24, 2023
1 check passed
@captainbrosset captainbrosset deleted the user/pabrosse/focus-mode-dom branch October 24, 2023 14:54
@captainbrosset captainbrosset mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehoffms mikehoffms mikehoffms approved these changes

Assignees
No one assigned
Labels
cat: devtools DevTools-related content. focus-mode-screenshots These PRs are about renewing screenshots in the DevTools docs for Focus Mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@captainbrosset @mikehoffms