Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Focus Mode] New images and content for the snippets article #2876

Merged
merged 4 commits into from
Oct 19, 2023
Merged

[Focus Mode] New images and content for the snippets article #2876

merged 4 commits into from
Oct 19, 2023

Conversation

captainbrosset
Copy link
Contributor

@captainbrosset captainbrosset commented Oct 17, 2023 •
edited by mikehoffms
Loading

Rendered article for review:
https://review.learn.microsoft.com/microsoft-edge/devtools-guide-chromium/javascript/snippets?branch=pr-en-us-2876
Before:
https://learn.microsoft.com/microsoft-edge/devtools-guide-chromium/javascript/snippets

This PR contains updated images for the snippets article, to match Focus Mode. The PR also contains some edits, to make the article easier to read.

AB#47107629

@captainbrosset captainbrosset added cat: devtools DevTools-related content. focus-mode-screenshots These PRs are about renewing screenshots in the DevTools docs for Focus Mode labels Oct 17, 2023
mikehoffms
mikehoffms requested changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writer/Editor review pass

@learn-build-service-prod
Copy link

Learn Build status updates of commit 28b2e19:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/javascript/snippets.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/command-menu.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/edit-snippet.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/javascript-search-create-new-snippet.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/javascript-search-run-command.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/javascript-search-show-snippets.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/javascript-sources-page-pane.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/javascript-sources-snippets-editor-saved.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/javascript-sources-snippets-editor-unsaved.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/javascript-sources-snippets-naming.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/javascript-sources-snippets-pane.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/javascript-sources-snippets-split-screen.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/javascript-sources-snippets-split-screen-after.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/more-tabs-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/more-tools-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/new-snippet.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/new-snippet-command-menu.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/run-snippet-from-command-menu.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/run-snippet-from-sources-tool.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/run-snippet-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/snippets-overview.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/sources-tool-page-pane.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/snippets-images/unsaved-changes.png ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

mikehoffms
mikehoffms approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writer/Editor review 2

@captainbrosset captainbrosset merged commit fad422e into user/pabrosse/focus-mode-july-2023 Oct 19, 2023
1 check passed
@captainbrosset captainbrosset deleted the user/pabrosse/focus-mode-snippets branch October 19, 2023 07:29
@captainbrosset captainbrosset mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehoffms mikehoffms mikehoffms approved these changes

Assignees
No one assigned
Labels
cat: devtools DevTools-related content. focus-mode-screenshots These PRs are about renewing screenshots in the DevTools docs for Focus Mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@captainbrosset @mikehoffms