Sorting parameters alphabetically in Set-SPOSite.md #785
Conversation
Sorted the parameters alphabetically Fixed <Guid[]> to [Guid[]]
|
Learn Build status updates of commit ebbce08: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
| @@ -22,64 +22,64 @@ Sets or updates one or more properties' values for a site collection. | |||
|
|
|||
| ```powershell | |||
| Set-SPOSite [-Identity] <SpoSitePipeBind> [-AllowSelfServiceUpgrade <Boolean>] [-Confirm] | |||
There was a problem hiding this comment.
Thanks for sorting all these existing params.
This [-AllowSelfServiceUpgrade] param is misplaced.
| @@ -22,64 +22,64 @@ Sets or updates one or more properties' values for a site collection. | |||
|
|
|||
| ```powershell | |||
| Set-SPOSite [-Identity] <SpoSitePipeBind> [-AllowSelfServiceUpgrade <Boolean>] [-Confirm] | |||
There was a problem hiding this comment.
Could the current format of having each param in each line being kept?
Set-SPOSite
[-Identity] <SpoSitePipeBind> [-Confirm]
[-AddRestrictedAccessControlGroups ]
...
There was a problem hiding this comment.
Could you also update the Set-SPOTenant document?
- The extra space should be removed before the ending brackets.
- The params are not sort in alphabetical order.
[-SensitivityLabel ]
[-DisableWorkflow2010 ]
[-Sites ]
[-AnyoneLinkTrackUsers ]
[-OneDriveBlockGuestsAsSiteAdmin ]
[-AllowSharingOutsideRestrictedAccessControlGroups ]
[-Workflows2013Enabled ]
[-IsCollabMeetingNotesFluidEnabled ]
[-IsLoopEnabled ]
[-DisablePersonalListCreation ]
[-DisableVivaConnectionsAnalytics ]
[-AppBypassInformationBarriers ]
[-DisableModernListTemplateIds <Guid[]> ]
[-EnableModernListTemplateIds <Guid[]> ]
[-HideSyncButtonOnTeamSite ]
[-StreamLaunchConfig ]
[-EnableRestrictedAccessControl ]
[-BlockDownloadFileTypeIds <SPBlockDownloadFileTypeId[]> ]
[-ExcludedBlockDownloadGroupIds <Guid[]> ]
[-RecycleBinRetentionPeriod ]
[-EnableMediaReactions ]
[-AllowSensitivityLabelOnRecords ]
[-ContentSecurityPolicyEnforcement ]
| [-Title <String>] [-WhatIf] [-AllowDownloadingNonWebViewableFiles <Boolean>] | ||
| [-BlockDownloadPolicy <Boolean>] | ||
| [-ClearRestrictedAccessControl <Boolean>] | ||
| [-ClearRestrictedAccessControl <SwitchParameter>] |
There was a problem hiding this comment.
Could you double check whether ClearRestrictedAccessControl alllows both <Boolean> and <SwitchParameter>?
They seems redundant to me.
| [-Title <String>] [-WhatIf] [-AllowDownloadingNonWebViewableFiles <Boolean>] | ||
| [-BlockDownloadPolicy <Boolean>] | ||
| [-ClearRestrictedAccessControl <Boolean>] | ||
| [-ClearRestrictedAccessControl <SwitchParameter>] | ||
| [-CommentsOnSitePagesDisabled <Boolean>] [-SocialBarOnSitePagesDisabled <Boolean>] |
There was a problem hiding this comment.
Why [-SocialBarOnSitePagesDisabled ] is here?
| [-CommentsOnSitePagesDisabled <Boolean>] [-SocialBarOnSitePagesDisabled <Boolean>] | ||
| [-ConditionalAccessPolicy <SPOConditionalAccessPolicyType>] | ||
| [-DefaultLinkPermission] |
| [-DefaultLinkToExistingAccess] | ||
| [-DefaultShareLinkRole <SharingRole>] | ||
| [-DefaultShareLinkScope <SharingScope>] | ||
| [-DefaultSharingLinkType] |
| [-DefaultShareLinkRole <SharingRole>] | ||
| [-DefaultShareLinkScope <SharingScope>] | ||
| [-DefaultSharingLinkType] | ||
| [-DenyAddAndCustomizePages <Boolean>] [-LocaleId <UInt32>] [-LockState <String>] [-MediaTranscription <MediaTranscriptionPolicyType>] [-NoWait] [-Owner <String>] |
There was a problem hiding this comment.
Multiple params are mixed in this line and not in the alphabetic order.
| [-DefaultShareLinkRole <SharingRole>] | ||
| [-DefaultShareLinkScope <SharingScope>] | ||
| [-DefaultSharingLinkType] | ||
| [-DenyAddAndCustomizePages <Boolean>] [-LocaleId <UInt32>] [-LockState <String>] [-MediaTranscription <MediaTranscriptionPolicyType>] [-NoWait] [-Owner <String>] |
There was a problem hiding this comment.
[-Confirm],[-NoWait] [-WhatIf] are part of CommonParameters. There is no need to list them specifically as you have [<CommonParameters>] listed at the end.
| [-SensitivityLabel <String>] | ||
| [-SharingAllowedDomainList <String>] | ||
| [-SharingBlockedDomainList <String>] | ||
| [-SharingCapability <SharingCapabilities>] [-StorageQuota <Int64>] [-StorageQuotaWarningLevel <Int64>] |
| [-SharingDomainRestrictionMode <SharingDomainRestrictionModes>] | ||
| [-ShowPeoplePickerSuggestionsForGuestUsers <Boolean>] | ||
| [-StorageQuotaReset] | ||
| [-Title <String>] [-WhatIf] [-AllowDownloadingNonWebViewableFiles <Boolean>] |
There was a problem hiding this comment.
Mis-placed [-AllowDownloadingNonWebViewableFiles ...] here and mixed Mutiple params.
Sorted the parameters alphabetically
Fixed <Guid[]> to [Guid[]]