Skip to content

Commit

Permalink
Split the limitation originator states to separate ones for min and max
Browse files Browse the repository at this point in the history
Fixes #278
  • Loading branch information
Michael Schröder committed Jan 2, 2025
1 parent 21c89cc commit f885378
Show file tree
Hide file tree
Showing 8 changed files with 434 additions and 15 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ The values of the state provide multiple manipulation modes:
### __WORK IN PROGRESS__

- (Michael Schroeder) [#130](https://github.com/MiSchroe/ioBroker.klf200/issues/130) Added a connection test button to help identify connection problems.
- (Michael Schroeder) [#278](https://github.com/MiSchroe/ioBroker.klf200/issues/278) Split the limitation originator state for min and max into separate ones.

### 1.3.5 (2024-11-20)

Expand Down Expand Up @@ -362,7 +363,7 @@ npm run release major|minor|patch|... [-- --dry]

The MIT License (MIT)

Copyright (c) 2018-2024 Michael Schroeder <[email protected]>
Copyright (c) 2018-2025 Michael Schroeder <[email protected]>

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand All @@ -385,4 +386,3 @@ THE SOFTWARE.
---

VELUX and the VELUX logo are registered trademarks of VKR Holding A/S.

2 changes: 1 addition & 1 deletion admin/custom/static/js/main.3fe851e1.js.map

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"dependencies": {
"@iobroker/adapter-core": "^3.2.2",
"@iobroker/dm-utils": "^0.6.11",
"klf-200-api": "^5.0.2",
"klf-200-api": "^6.0.0",
"net-ping": "^1.2.4",
"promise-timeout": "^1.3.0"
},
Expand Down
156 changes: 156 additions & 0 deletions src/setupProducts.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -313,14 +313,38 @@ describe("setupProducts", function () {
state: "limitationMPOriginator",
value: 1,
},
{
state: "limitationMPOriginatorMin",
value: 1,
},
{
state: "limitationMPOriginatorMax",
value: 1,
},
{
state: "limitationMPTimeRaw",
value: 253,
},
{
state: "limitationMPTimeRawMin",
value: 253,
},
{
state: "limitationMPTimeRawMax",
value: 253,
},
{
state: "limitationMPTime",
value: Infinity,
},
{
state: "limitationMPTimeMin",
value: Infinity,
},
{
state: "limitationMPTimeMax",
value: Infinity,
},
{
state: "limitationFP1MinRaw",
value: 0x0000,
Expand All @@ -341,14 +365,38 @@ describe("setupProducts", function () {
state: "limitationFP1Originator",
value: 1,
},
{
state: "limitationFP1OriginatorMin",
value: 1,
},
{
state: "limitationFP1OriginatorMax",
value: 1,
},
{
state: "limitationFP1TimeRaw",
value: 253,
},
{
state: "limitationFP1TimeRawMin",
value: 253,
},
{
state: "limitationFP1TimeRawMax",
value: 253,
},
{
state: "limitationFP1Time",
value: Infinity,
},
{
state: "limitationFP1TimeMin",
value: Infinity,
},
{
state: "limitationFP1TimeMax",
value: Infinity,
},
{
state: "limitationFP2MinRaw",
value: 0x0000,
Expand All @@ -369,14 +417,38 @@ describe("setupProducts", function () {
state: "limitationFP2Originator",
value: 1,
},
{
state: "limitationFP2OriginatorMin",
value: 1,
},
{
state: "limitationFP2OriginatorMax",
value: 1,
},
{
state: "limitationFP2TimeRaw",
value: 253,
},
{
state: "limitationFP2TimeRawMin",
value: 253,
},
{
state: "limitationFP2TimeRawMax",
value: 253,
},
{
state: "limitationFP2Time",
value: Infinity,
},
{
state: "limitationFP2TimeMin",
value: Infinity,
},
{
state: "limitationFP2TimeMax",
value: Infinity,
},
{
state: "limitationFP3MinRaw",
value: 0x0000,
Expand All @@ -397,14 +469,38 @@ describe("setupProducts", function () {
state: "limitationFP3Originator",
value: 1,
},
{
state: "limitationFP3OriginatorMin",
value: 1,
},
{
state: "limitationFP3OriginatorMax",
value: 1,
},
{
state: "limitationFP3TimeRaw",
value: 253,
},
{
state: "limitationFP3TimeRawMin",
value: 253,
},
{
state: "limitationFP3TimeRawMax",
value: 253,
},
{
state: "limitationFP3Time",
value: Infinity,
},
{
state: "limitationFP3TimeMin",
value: Infinity,
},
{
state: "limitationFP3TimeMax",
value: Infinity,
},
{
state: "limitationFP4MinRaw",
value: 0x0000,
Expand All @@ -425,14 +521,38 @@ describe("setupProducts", function () {
state: "limitationFP4Originator",
value: 1,
},
{
state: "limitationFP4OriginatorMin",
value: 1,
},
{
state: "limitationFP4OriginatorMax",
value: 1,
},
{
state: "limitationFP4TimeRaw",
value: 253,
},
{
state: "limitationFP4TimeRawMin",
value: 253,
},
{
state: "limitationFP4TimeRawMax",
value: 253,
},
{
state: "limitationFP4Time",
value: Infinity,
},
{
state: "limitationFP4TimeMin",
value: Infinity,
},
{
state: "limitationFP4TimeMax",
value: Infinity,
},
{
state: "refreshLimitation",
value: false,
Expand Down Expand Up @@ -693,36 +813,66 @@ describe("setupProducts", function () {
"test.0.products.0.limitationMPMin",
"test.0.products.0.limitationMPMax",
"test.0.products.0.limitationMPOriginator",
"test.0.products.0.limitationMPOriginatorMin",
"test.0.products.0.limitationMPOriginatorMax",
"test.0.products.0.limitationMPTimeRaw",
"test.0.products.0.limitationMPTimeRawMin",
"test.0.products.0.limitationMPTimeRawMax",
"test.0.products.0.limitationMPTime",
"test.0.products.0.limitationMPTimeMin",
"test.0.products.0.limitationMPTimeMax",
"test.0.products.0.limitationFP1MinRaw",
"test.0.products.0.limitationFP1MaxRaw",
"test.0.products.0.limitationFP1Min",
"test.0.products.0.limitationFP1Max",
"test.0.products.0.limitationFP1Originator",
"test.0.products.0.limitationFP1OriginatorMin",
"test.0.products.0.limitationFP1OriginatorMax",
"test.0.products.0.limitationFP1TimeRaw",
"test.0.products.0.limitationFP1TimeRawMin",
"test.0.products.0.limitationFP1TimeRawMax",
"test.0.products.0.limitationFP1Time",
"test.0.products.0.limitationFP1TimeMin",
"test.0.products.0.limitationFP1TimeMax",
"test.0.products.0.limitationFP2MinRaw",
"test.0.products.0.limitationFP2MaxRaw",
"test.0.products.0.limitationFP2Min",
"test.0.products.0.limitationFP2Max",
"test.0.products.0.limitationFP2Originator",
"test.0.products.0.limitationFP2OriginatorMin",
"test.0.products.0.limitationFP2OriginatorMax",
"test.0.products.0.limitationFP2TimeRaw",
"test.0.products.0.limitationFP2TimeRawMin",
"test.0.products.0.limitationFP2TimeRawMax",
"test.0.products.0.limitationFP2Time",
"test.0.products.0.limitationFP2TimeMin",
"test.0.products.0.limitationFP2TimeMax",
"test.0.products.0.limitationFP3MinRaw",
"test.0.products.0.limitationFP3MaxRaw",
"test.0.products.0.limitationFP3Min",
"test.0.products.0.limitationFP3Max",
"test.0.products.0.limitationFP3Originator",
"test.0.products.0.limitationFP3OriginatorMin",
"test.0.products.0.limitationFP3OriginatorMax",
"test.0.products.0.limitationFP3TimeRaw",
"test.0.products.0.limitationFP3TimeRawMin",
"test.0.products.0.limitationFP3TimeRawMax",
"test.0.products.0.limitationFP3Time",
"test.0.products.0.limitationFP3TimeMin",
"test.0.products.0.limitationFP3TimeMax",
"test.0.products.0.limitationFP4MinRaw",
"test.0.products.0.limitationFP4MaxRaw",
"test.0.products.0.limitationFP4Min",
"test.0.products.0.limitationFP4Max",
"test.0.products.0.limitationFP4Originator",
"test.0.products.0.limitationFP4OriginatorMin",
"test.0.products.0.limitationFP4OriginatorMax",
"test.0.products.0.limitationFP4TimeRaw",
"test.0.products.0.limitationFP4TimeRawMin",
"test.0.products.0.limitationFP4TimeRawMax",
"test.0.products.0.limitationFP4Time",
"test.0.products.0.limitationFP4TimeMin",
"test.0.products.0.limitationFP4TimeMax",
];
const objectList: ioBroker.NonNullCallbackReturnTypeOf<
ioBroker.GetObjectListCallback<ioBroker.Object>
Expand Down Expand Up @@ -900,8 +1050,14 @@ describe("setupProducts", function () {
"limitationFP1Min",
"limitationFP1Max",
"limitationFP1Originator",
"limitationFP1OriginatorMin",
"limitationFP1OriginatorMax",
"limitationFP1TimeRaw",
"limitationFP1TimeRawMin",
"limitationFP1TimeRawMax",
"limitationFP1Time",
"limitationFP1TimeMin",
"limitationFP1TimeMax",
]) {
it(`shouldn't create a state for ${expectedState} of FP1`, async function () {
const disposalMap = new DisposalMap();
Expand Down
Loading

0 comments on commit f885378

Please sign in to comment.