Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update send calls default calls #389

Merged
merged 2 commits into from
Feb 12, 2025
Merged

fix: update send calls default calls #389

merged 2 commits into from
Feb 12, 2025

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Feb 11, 2025 •
edited
Loading

Update default calls in wallet_sendCalls request.

  • Reduce value to 1 Gwei and 0.5 Gwei.
  • Use random address rather than malicious address for second call.
  • Add version to request.

@matthewwalsh0 matthewwalsh0 requested a review from seaona February 11, 2025 20:16
seaona
seaona reviewed Feb 12, 2025
View reviewed changes
src/components/transactions/eip5792/sendCalls.js
@@ -143,6 +145,7 @@ export function sendCallsComponent(parentContainer) {
const calls = useInputs ? getCalls() : DEFAULT_CALLS;

return {
version: VERSION,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@matthewwalsh0 matthewwalsh0 merged commit 6f35977 into main Feb 12, 2025
8 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/send-calls-default-data branch February 12, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaona seaona seaona approved these changes

Assignees
No one assigned
Labels
team-confirmations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewwalsh0 @seaona