feat: add batch and queue signature and transactions #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaona
commented
Feb 28, 2024
| @@ -726,6 +726,7 @@ <h4 class="card-title"> | |||
| </div> | |||
| </div> | |||
| </div> | |||
| </div> | |||
There was a problem hiding this comment.
this closing div was missing
This was referenced Feb 28, 2024
jpuri
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following functionalitites in the test dapp:
Note: both the transaction and the signature are malicious, meaning that we are able not only to test the batch/queue functionalities for the transaction controller but also the ppom validations under this stress circumstances.
This has uncovered the following issues:
and help find a way to reproduce these 2:
Screenshots
Extension
dapp-batch-queue-extension.mp4
Mobile
dapp-batch-queue-mobile.mp4