-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Bump to webpack 5; use Node.js >= 18 #264
BREAKING: Bump to webpack 5; use Node.js >= 18 #264
Conversation
c316c6d
to
2e774ca
Compare
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @lavamoat/[email protected], [email protected] |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
06bb22a
to
d72f0a6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
- devDeps: webpack-cli@^3.3.12->^5.1.4 - devDeps: webpack-dev-server@^3.11.2->^4.15.1
d72f0a6
to
a0abf65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The signing examples were broken as of the update to Webpack v5 (#264). The "verification" button for the signatures relies upon the Node.js `assert` and `stream` APIs. Polyfills have been added for both of these. Additionally, the `assert` polyfill itself relies upon the Node.js `process` API, and expects `process` to be a global. A polyfill has been added for `process`, and it has been set as a global.
The signing examples were broken as of the update to Webpack v5 (#264). The "verification" button for the signatures relies upon the Node.js `assert` and `stream` APIs. Polyfills have been added for both of these. Additionally, the `assert` polyfill itself relies upon the Node.js `process` API, and expects `process` to be a global. A polyfill has been added for `process`, and it has been set as a global.
main
webpack
from 4 to 5webpack start
seems to run fine locally for me but reviewers are encouraged to test manually.