Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

19.0.0 #402

Merged
merged 3 commits into from
Jan 23, 2025
Merged

19.0.0 #402

merged 3 commits into from
Jan 23, 2025

Conversation

github-actions[bot]
Copy link
Contributor

This is the release candidate for version 19.0.0.

github-actions and others added 2 commits January 23, 2025 17:31
@cryptodev-2s cryptodev-2s self-assigned this Jan 23, 2025
@cryptodev-2s cryptodev-2s marked this pull request as ready for review January 23, 2025 17:33
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner January 23, 2025 17:33
@cryptodev-2s cryptodev-2s requested review from Gudahtt and jiexi January 23, 2025 17:40
mcmire
mcmire reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth mentioning the changes to initializeInpageProvider and createExternalExtensionProvider at all? It seems like we haven't change their behavior so maybe we can remove those changelog entries? Or do we think it's still worth mentioning in case something goes wrong?

@cryptodev-2s
Copy link
Contributor

Is it worth mentioning the changes to initializeInpageProvider and createExternalExtensionProvider at all? It seems like we haven't change their behavior so maybe we can remove those changelog entries? Or do we think it's still worth mentioning in case something goes wrong?

Yes, exactly. If something goes wrong, we can associate it with the breaking changes made in the underlying layer.

mcmire
mcmire approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fantastic changelog entries btw :)

@cryptodev-2s cryptodev-2s merged commit 11acfb0 into main Jan 23, 2025
20 checks passed
@cryptodev-2s cryptodev-2s deleted the release/19.0.0 branch January 23, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

@jiexi jiexi Awaiting requested review from jiexi

Assignees

@cryptodev-2s cryptodev-2s

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cryptodev-2s @mcmire