Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Core controllers v300 #13528

Merged
merged 10 commits into from
Feb 17, 2025
Merged

chore: Core controllers v300 #13528

merged 10 commits into from
Feb 17, 2025

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Feb 14, 2025

Description

  • Update accounts controller (^24), assets controller(^50) and transaction controller(^46)
  • Handle breaking changes of assets controllers
  • Update the patch of assets controllers to be on v50
  • Add MultichainNetworkController v0.1.1 (Although only added and not used at this PR, setActiveNetwork will be refactored in a follow up PR)

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2025-02-17.at.15.50.13.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…ler and handle breaking changes of assets controllers, update the patch of assets controllers to be on v50
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Feb 14, 2025
Copy link

socket-security bot commented Feb 14, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

…ckground state to unit tests and fixtures, add constants and types to engine files to allow the events to be called and subscribe and respective controller actions, add unit tests to cover new code added
@tommasini tommasini marked this pull request as ready for review February 17, 2025 11:49
@tommasini tommasini requested review from a team as code owners February 17, 2025 11:49
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 17, 2025
Copy link
Contributor

github-actions bot commented Feb 17, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b0dda1b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/790b1a31-239d-4dbe-a455-5267585b74b2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini
Copy link
Contributor Author

@SocketSecurity ignore-all
All those packages are internal and we trust those

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 17, 2025
Copy link
Contributor

github-actions bot commented Feb 17, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2bce9c0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b382b07a-80a8-4b3a-b069-68f9a2a7276a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini changed the title chore: Update accounts, assets, transaction controllers chore: Core controllers v300 Feb 17, 2025
salimtb
salimtb previously approved these changes Feb 17, 2025
Copy link
Contributor

@salimtb salimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assets changes LGTM

MarioAslau
MarioAslau previously approved these changes Feb 17, 2025
@tommasini tommasini enabled auto-merge February 17, 2025 20:24
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed,

  • app/components/Views/AddAccountActions/AddAccountActions.tsx
  • app/core/Engine/Engine.ts
  • app/core/Engine/controllers/AccountsController/constants.ts
  • app/core/Engine/controllers/AccountsController/utils.test.ts
  • app/core/Engine/controllers/MultichainNetworkController/index.test.ts
  • app/core/Engine/controllers/MultichainNetworkController/index.ts
  • app/core/Engine/types.ts
  • app/selectors/multichain/multichain.test.ts
  • app/core/Multichain/constants.ts
  • app/selectors/multichain/multichain.ts
  • e2e/fixtures/fixture-builder.js

@tommasini tommasini dismissed stale reviews from MarioAslau and salimtb via c079ba8 February 17, 2025 21:08
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 17, 2025
Copy link
Contributor

github-actions bot commented Feb 17, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6397f1c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5caba08e-ea6f-4599-9d56-7f0209475270

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tommasini tommasini added this pull request to the merge queue Feb 17, 2025
Merged via the queue into main with commit 9efdecc Feb 17, 2025
43 checks passed
@tommasini tommasini deleted the chore/update-core-v299 branch February 17, 2025 23:00
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 17, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.42.0 Issue or pull request that will be included in release 7.42.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform Mobile Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants