-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Core controllers v300 #13528
chore: Core controllers v300 #13528
Conversation
…ler and handle breaking changes of assets controllers, update the patch of assets controllers to be on v50
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
…ckground state to unit tests and fixtures, add constants and types to engine files to allow the events to be called and subscribe and respective controller actions, add unit tests to cover new code added
…r and a respective unit test files
|
@SocketSecurity ignore-all |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assets changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed,
app/components/Views/AddAccountActions/AddAccountActions.tsx
app/core/Engine/Engine.ts
app/core/Engine/controllers/AccountsController/constants.ts
app/core/Engine/controllers/AccountsController/utils.test.ts
app/core/Engine/controllers/MultichainNetworkController/index.test.ts
app/core/Engine/controllers/MultichainNetworkController/index.ts
app/core/Engine/types.ts
app/selectors/multichain/multichain.test.ts
app/core/Multichain/constants.ts
app/selectors/multichain/multichain.ts
e2e/fixtures/fixture-builder.js
app/core/Engine/controllers/MultichainNetworkController/index.test.ts
Outdated
Show resolved
Hide resolved
app/core/Engine/controllers/MultichainNetworkController/index.test.ts
Outdated
Show resolved
Hide resolved
app/core/Engine/controllers/MultichainNetworkController/index.test.ts
Outdated
Show resolved
Hide resolved
…test.ts Co-authored-by: Gustavo Antunes <[email protected]>
…test.ts Co-authored-by: Gustavo Antunes <[email protected]>
…test.ts Co-authored-by: Gustavo Antunes <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
|
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-02-17.at.15.50.13.mov
Pre-merge author checklist
Pre-merge reviewer checklist