-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace redesign confirmation BottomModal with BottomSheet #13268
base: main
Are you sure you want to change the base?
Conversation
no need because BottomSheetDialog provides background color
- affects only old confirmations - fix marginBottom on TransactionReview
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Bitrise✅✅✅ Commit hash: 50594e4 Note
|
@@ -595,7 +595,7 @@ exports[`Approval render matches snapshot 1`] = ` | |||
<View | |||
style={ | |||
{ | |||
"marginBottom": -8, | |||
"marginBottom": 8, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes missing padding between blockaid banner alert and account header
Description
Related issues
Fixes: #13267
Todo follow-up - Related Issue: #12656
Manual testing steps
Test BottomSheets and BlockaidBanner alerts work as expected. Test redesign confirmation page works as expected
Screenshots/Recordings
Before using BottomModal and no scroll behavior
CleanShot.2025-01-30.at.01.11.16.mp4
After using BottomSheet with scroll behavior
CleanShot.2025-01-30.at.02.18.53.mp4
Before 70% min height
After remove 70% min height
Before Transaction Review BlockaidBanner negative padding
**After Transaction Review BlockaidBanner positive padding **
Pre-merge author checklist
Pre-merge reviewer checklist