Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace BottomModal with BottomSheet in redesign confirmation #13267

Open
9 tasks
digiwand opened this issue Jan 30, 2025 · 0 comments · May be fixed by #13268
Open
9 tasks

refactor: Replace BottomModal with BottomSheet in redesign confirmation #13267

digiwand opened this issue Jan 30, 2025 · 0 comments · May be fixed by #13268
Assignees
Labels
team-confirmations Push issues to confirmations team

Comments

@digiwand
Copy link
Contributor

What is this about?

Replace BottomModal with BottomSheet. Creating additional modals and tooltips on top of BottomModal has limitations and is cumbersome. We should revert BottomModal in favor of the DS BottomSheet

Links:
https://metamask-consensys.notion.site/Bottom-Sheet-302164aff8a74b6eb721f49586f88ecd

Related to: #12656

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant