Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 4279 - Hide token images in AccountListItem #30556

Closed
wants to merge 2 commits into from
Closed

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Feb 25, 2025

Description

Hides token image in the AccountListItem on every other build but main

Open in GitHub Codespaces

Related issues

Reference: https://github.com/MetaMask/MetaMask-planning/issues/4279

Manual testing steps

  1. Start MetaMask with Flask build flag
  2. Open account list item
  3. Don't see icons

Screenshots/Recordings

Before

After

SCR-20250225-kaxw

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner February 25, 2025 17:02
@darkwing darkwing requested a review from GuillaumeRx February 25, 2025 17:02
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing changed the title fix 4279 - Hide token images in AccountListItem fix: 4279 - Hide token images in AccountListItem Feb 25, 2025
Copy link
Contributor

@GuillaumeRx GuillaumeRx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fix at all the issue we had

  1. As mentioned in the issue, Snaps UI is also something available in the main release making the code-fences here useless and introducing a side effect to the Snap UI component.

  2. The balances will still not be aggregated in the two cases exposed in the issues.

@darkwing darkwing closed this Feb 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants