Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add profile_id as a metametrics user trait #30552

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Feb 25, 2025

Description

This PR adds profile_id as a MetaMetrics user trait so that it gets attached to every event when present in the state.

Open in GitHub Codespaces

Related issues

Related to: https://consensyssoftware.atlassian.net/browse/IDENTITY-39

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mathieuartu mathieuartu marked this pull request as ready for review February 25, 2025 16:03
@metamaskbot
Copy link
Collaborator

Builds ready [cdcede6]
Page Load Metrics (1826 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16212082182612560
domContentLoaded15562040179412861
load15672144182613464
domInteractive26114402412
backgroundConnect10102332613
firstReactRender1571362311
getState5421284
initialActions01000
loadScripts11361595134710752
setupStore85419178
uiStartup18282591209918087
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 127 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 25 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants