fix: clear transaction data after submission or cancellation #30546
+17
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| @@ -225,6 +226,7 @@ const Footer = () => { | |||
| } | |||
| dispatch(updateCustomNonce('')); | |||
| dispatch(setNextNonce('')); | |||
| dispatch(clearConfirmTransaction()); | |||
There was a problem hiding this comment.
Minor, but could we create a local function to remove the duplication such as resetTransactionState?
Builds ready [f0a2136]
Page Load Metrics (1891 ± 90 ms)
Bundle size diffs
|
matthewwalsh0
approved these changes
Feb 25, 2025
| @@ -178,6 +178,12 @@ const Footer = () => { | |||
| (!isScrollToBottomCompleted && !isSignature) || | |||
| hardwareWalletRequiresConnection; | |||
|
|
|||
| const resetTransactionState = () => { | |||
There was a problem hiding this comment.
Minor, unit tests would be nice but I appreciate this is high priority.
OGPoyraz
approved these changes
Feb 25, 2025
metamaskbot
added
the
release-12.14.0
|
Tested on Screen.Recording.2025-02-25.at.09.55.22.mov |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes: #29374
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist